feature(nemesis): introduce lock for target selection #7016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fruch
added
test-provision-aws
fruch
force-pushed
the
add_nemesis_target_lock
branch
from
c413483 to
7954f29
Compare
fruch
force-pushed
the
add_nemesis_target_lock
branch
2 times, most recently
from
18ed779 to
9e72716
Compare
fruch
force-pushed
the
add_nemesis_target_lock
branch
2 times, most recently
from
dfd5080 to
097ec3b
Compare
fruch
removed
test-provision-aws
vponomaryov
requested changes
Jan 12, 2024
There was a problem hiding this comment.
Please, remove commits that were merged as part of another your PR: https://github.com/scylladb/scylla-cluster-tests/pull/7024/commits
fruch
force-pushed
the
add_nemesis_target_lock
branch
from
097ec3b to
4b25a0a
Compare
removed, and solved conflicts |
vponomaryov
reviewed
Jan 18, 2024
fruch
force-pushed
the
add_nemesis_target_lock
branch
from
4b25a0a to
8358b9e
Compare
vponomaryov
reviewed
Jan 30, 2024
vponomaryov
requested changes
Jan 30, 2024
since we run into multiple cases on parallel nemesis that there were multiple nemesis using the same node we are introducing a lock over the selection of target nodes so we won't be able to pick it multiple times Fixes: scylladb#6553
fruch
force-pushed
the
add_nemesis_target_lock
branch
from
8358b9e to
32e8c89
Compare
2 tasks
fruch
added a commit
to fruch/scylla-cluster-tests
that referenced
this pull request
Feb 21, 2024
in PR scylladb#7016 there was a change that drop this part from the code without it, we can get into case that nemesis which are calling this function directly, might leave some nodes mark with `running_nemesis` while no cleaup code can figure it out, and would unmark only the current target selected. Fixes: scylladb#7220
2 tasks
vponomaryov
pushed a commit
that referenced
this pull request
Feb 21, 2024
in PR #7016 there was a change that drop this part from the code without it, we can get into case that nemesis which are calling this function directly, might leave some nodes mark with `running_nemesis` while no cleaup code can figure it out, and would unmark only the current target selected. Fixes: #7220
fruch
added
backport/2023.1
Merged
3 tasks
This was referenced Aug 28, 2024
Merged
3 tasks
mergify bot
pushed a commit
that referenced
this pull request
Aug 28, 2024
in PR #7016 there was a change that drop this part from the code without it, we can get into case that nemesis which are calling this function directly, might leave some nodes mark with `running_nemesis` while no cleaup code can figure it out, and would unmark only the current target selected. Fixes: #7220 (cherry picked from commit dbb58dc)
mergify bot
pushed a commit
that referenced
this pull request
Aug 28, 2024
in PR #7016 there was a change that drop this part from the code without it, we can get into case that nemesis which are calling this function directly, might leave some nodes mark with `running_nemesis` while no cleaup code can figure it out, and would unmark only the current target selected. Fixes: #7220 (cherry picked from commit dbb58dc)
This was referenced Aug 28, 2024
fruch
added a commit
that referenced
this pull request
Aug 28, 2024
in PR #7016 there was a change that drop this part from the code without it, we can get into case that nemesis which are calling this function directly, might leave some nodes mark with `running_nemesis` while no cleaup code can figure it out, and would unmark only the current target selected. Fixes: #7220 (cherry picked from commit dbb58dc)
fruch
added a commit
that referenced
this pull request
Aug 28, 2024
in PR #7016 there was a change that drop this part from the code without it, we can get into case that nemesis which are calling this function directly, might leave some nodes mark with `running_nemesis` while no cleaup code can figure it out, and would unmark only the current target selected. Fixes: #7220 (cherry picked from commit dbb58dc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since we run into multiple cases on parallel nemesis that there were multiple nemesis using the same node
we are introducing a lock over the selection of target nodes so we won't be able to pick it multiple times
Fixes: #6553
Testing
PR pre-checks (self review)
backportlabelsReminders
sdcm/sct_config.py)unit-test/folder)