[Backport 2024.1] fix(nemesis): make sure set_target_node
always set current_disruption
#8471
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before there was two seprate calls to
set_target_node
and toset_current_disruption
that could end up withset_target_node
setting None to thetarget_node.running_nemesis
this fix move
set_current_disruption
intoset_target_node
to avoid this problem, and also introduce a new paramter toset_target_node
so any user of it can set what's the data that would be saved on the target node (it's only for debugging)Fixes: #8198
Testing
PR pre-checks (self review)
backport
labelsReminders
sdcm/sct_config.py
)unit-test/
folder)(cherry picked from commit a12ee91)
Parent PR: #8381