[Backport 2024.1] fix(nemesis): set_target_node should first give up current target
#8494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
in PR #7016 there was a change that drop this part from the code without it, we can get into case that nemesis which are calling this function directly, might leave some nodes mark with `running_nemesis` while no cleaup code can figure it out, and would unmark only the current target selected. Fixes: #7220 (cherry picked from commit dbb58dc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in PR #7016 there was a change that drop this part from the code without it, we can get into case that nemesis which are calling this function directly, might leave some nodes mark with
running_nemesiswhile no cleaup code can figure it out, and would unmark only the current target selected.Fixes: #7220
Testing
PR pre-checks (self review)
backportlabelsReminders
sdcm/sct_config.py)unit-test/folder)(cherry picked from commit dbb58dc)
Parent PR: #7222