Tooltip: Tooltip V2 as an experimental/draft with the new popover API #3394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 133246d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
broccolinisoup
temporarily deployed
to
github-pages
GitHub Actions
Inactive
broccolinisoup
temporarily deployed
to
github-pages
GitHub Actions
Inactive
broccolinisoup
temporarily deployed
to
github-pages
GitHub Actions
Inactive
broccolinisoup
temporarily deployed
to
github-pages
GitHub Actions
Inactive
broccolinisoup
temporarily deployed
to
github-pages
GitHub Actions
Inactive
broccolinisoup
temporarily deployed
to
github-pages
GitHub Actions
Inactive
broccolinisoup
temporarily deployed
to
github-pages
GitHub Actions
Inactive
broccolinisoup
force-pushed
the
bs/experimental-tooltip-with-popover
branch
from
81b09de to
a05474e
Compare
broccolinisoup
temporarily deployed
to
github-pages
GitHub Actions
Inactive
siddharthkp
approved these changes
Sep 25, 2023
broccolinisoup
commented
Sep 25, 2023
broccolinisoup
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes here.
This PR implements the new popover API (with polyfills), updates the components API that was accepted on https://github.com/github/primer/pull/2339 and addresses the accessibility remediations that were found on https://github.com/github/primer/issues/1790.
Integration PR at dotcom: https://github.com/github/github/pull/288842 (Hubbers link only)
Huge thanks to @keithamus for pairing with me on the new popover API! ✨ This is the first popover implementation on React so I would really love your thoughts and feedback 🙏🏻
TODO
ActionMenu.Anchorwhen the trigger is a buttonScreenshots
Please see the storybook examples here: https://primer-dc05b46969-13348165.drafts.github.io/storybook/?path=/story/drafts-components-tooltip--default
(Currently there is no caret on the tooltip as we are in the process of proposing this as a new visual design - reference)
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.