Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Tooltip v2 to use CSS Modules 💖 #3767

Closed
broccolinisoup opened this issue Sep 26, 2023 · 3 comments
Closed

Update Tooltip v2 to use CSS Modules 💖 #3767

broccolinisoup opened this issue Sep 26, 2023 · 3 comments
Assignees
Labels
component: Tooltip Issues related to the Tooltip component react Stale

Comments

@broccolinisoup
Copy link
Member

broccolinisoup commented Sep 26, 2023

I'm creating this issue for tracking purposes. We plan to update the Tooltip v2 (draft) to use CSS modules and here are CSS variable suggestions @langermank left on the #3394

  1. https://github.com/primer/react/blob/main/src/drafts/Tooltip/Tooltip.tsx#L16
- padding: 0.5em 0.75em;
+ padding: var(--base-size-8) var(--base-size-4);
  1. https://github.com/primer/react/blob/main/src/drafts/Tooltip/Tooltip.tsx#L44
- font: normal normal 11px/1.5 ${get('fonts.normal')};
+ font: var(--text-body-shorthand-small);
  1. https://github.com/primer/react/blob/main/src/drafts/Tooltip/Tooltip.tsx#L46
-  color: ${get('colors.fg.onEmphasis')};
+  color: var(--fgColor-onEmphasis);
  1. https://github.com/primer/react/blob/main/src/drafts/Tooltip/Tooltip.tsx#L50
-  background: ${get('colors.neutral.emphasisPlus')};
+  background: var(--bgColor-emphasis);
  1. https://github.com/primer/react/blob/main/src/drafts/Tooltip/Tooltip.tsx#L51
-   border-radius: ${get('radii.2')};
+  border-radius: var(--borderRadius-medium);
@broccolinisoup broccolinisoup added component: Tooltip Issues related to the Tooltip component react labels Sep 26, 2023
@broccolinisoup broccolinisoup self-assigned this Sep 26, 2023
Copy link
Contributor

Hi! This issue has been marked as stale because it has been open with no activity for 180 days. You can comment on the issue or remove the stale label to keep it open. If you do nothing, this issue will be closed in 7 days.

@github-actions github-actions bot added Stale and removed Stale labels Mar 24, 2024
Copy link
Contributor

Hi! This issue has been marked as stale because it has been open with no activity for 180 days. You can comment on the issue or remove the stale label to keep it open. If you do nothing, this issue will be closed in 7 days.

@github-actions github-actions bot added the Stale label Sep 23, 2024
@jonrohan
Copy link
Member

Closing this to track in https://github.com/orgs/github/projects/19578/views/1 and part of https://github.com/github/primer/issues/4028

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: Tooltip Issues related to the Tooltip component react Stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants