Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tooltip: Tooltip V2 as an experimental/draft with the new popover API #3394
Tooltip: Tooltip V2 as an experimental/draft with the new popover API #3394
Changes from 41 commits
2ae8d45
a8aad6e
c01b61f
3b65cd2
f846b38
13d3aa2
43db250
46630d4
4b0dd7d
49b2ca8
cd1bd7f
99469e1
a8b8fb6
966bdf8
851a6c2
1632030
beeace0
7091285
69dbf4e
067a09e
364d2ea
c64323f
8b6da3e
2b3bf14
51f738f
8e7d406
12e5bde
e65ff6f
abddbf5
7c24bb0
65ed0f9
6507faf
0fd9735
7e37448
70d09dc
ab7edcd
ed27858
b2d30fb
78a2f35
14b7ecd
f2c4157
f48a15f
782dbdf
1849f61
22a48bb
ec44813
3e0cb79
0c8c5e6
def9954
a9e8019
9527ea4
8cd5ebd
229c527
3f29dad
ba5d060
edc0615
b56fb96
a05474e
bb78acc
a662853
133246d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have honestly forgotten if we want to keep
noDelay
or remove it 😅I personally think Tooltip should be very snappy by default and we should not have this customisable based on a page, that would leave to slight inconsistencies that feel unpolished 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll tag @langermank because we are a proposal for some visual changes in the design repo and might be good idea to bring it up there if this is something we are going to go forward with it 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh great callout @siddharthkp! I agree Tooltip should be snappy by default, so I would actually remove this prop and remove the delay in the default styles. If there's a delay in Primer View Components I'll make sure to remove it as well when I update the caret styles.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds great! I'll update the code, docs and stories accordingly ✨
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love to see it!