Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HuaweiAds: Fixing the fill rate issue #3219

Merged
merged 6 commits into from
Oct 19, 2023
Merged

HuaweiAds: Fixing the fill rate issue #3219

merged 6 commits into from
Oct 19, 2023

Conversation

ahmetfaruk59
Copy link
Contributor

@ahmetfaruk59 ahmetfaruk59 commented Oct 14, 2023

handle instances and bind it to request.

@github-actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 56d9348

huaweiads

Refer here for heat map coverage report

github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:266:	MakeRequests				93.3%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:324:	getFinalEndPoint			85.7%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:354:	MakeBids				91.7%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:381:	Builder					100.0%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:394:	getExtraInfo				94.1%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:429:	getHeaders				88.9%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:445:	getReqJson				90.0%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:460:	getReqAdslot30				100.0%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:482:	checkAndExtractOpenrtbFormat		100.0%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:510:	getBannerFormat				100.0%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:526:	getNativeFormat				94.3%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:580:	getVideoFormat				100.0%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:593:	convertAdtypeStringToInteger		60.0%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:617:	getReqAppInfo				93.8%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:651:	getFinalPkgName				93.8%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:686:	getClientTime				75.0%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:706:	getReqDeviceInfo			96.6%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:749:	getCountryCode				100.0%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:762:	convertCountryCode			75.0%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:783:	getCountryCodeFromMCC			100.0%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:800:	getDeviceIDFromUserExt			100.0%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:845:	getReqNetWorkInfo			85.7%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:881:	getReqRegsInfo				100.0%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:890:	getReqGeoInfo				100.0%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:902:	getReqConsentInfo			80.0%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:912:	unmarshalExtImpHuaweiAds		88.2%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:939:	checkRespStatusCode			77.8%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:962:	checkHuaweiAdsResponseRetcode		80.0%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:976:	convertHuaweiAdsRespToBidderResp	90.2%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:1045:	getNurl					66.7%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:1058:	handleHuaweiAdsContent			87.5%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:1078:	extractAdmBanner			60.0%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:1100:	extractAdmNative			91.9%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:1220:	getDecodeValue				80.0%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:1231:	jsonEncode				100.0%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:1240:	extractAdmPicture			90.9%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:1303:	getClickUrl				100.0%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:1320:	getDspImpClickTrackings			100.0%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:1334:	getStrings				87.5%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:1349:	getDuration				100.0%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:1356:	extractAdmVideo				85.4%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:1519:	getVastImpClickErrorTrackingUrls	100.0%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:1539:	getVastEventTrackingUrls		100.0%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:1559:	computeHmacSha256			100.0%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:1566:	getDigestAuthorization			100.0%
total:									(statements)				90.8%

@github-actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 44940f4

huaweiads

Refer here for heat map coverage report

github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:266:	MakeRequests				93.3%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:324:	getFinalEndPoint			85.7%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:354:	MakeBids				91.7%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:381:	Builder					100.0%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:394:	getExtraInfo				94.1%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:429:	getHeaders				88.9%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:445:	getReqJson				90.0%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:460:	getReqAdslot30				100.0%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:482:	checkAndExtractOpenrtbFormat		100.0%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:510:	getBannerFormat				100.0%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:526:	getNativeFormat				94.3%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:580:	getVideoFormat				100.0%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:593:	convertAdtypeStringToInteger		60.0%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:617:	getReqAppInfo				93.8%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:651:	getFinalPkgName				93.8%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:686:	getClientTime				75.0%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:706:	getReqDeviceInfo			96.6%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:749:	getCountryCode				100.0%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:762:	convertCountryCode			75.0%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:783:	getCountryCodeFromMCC			100.0%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:800:	getDeviceIDFromUserExt			100.0%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:845:	getReqNetWorkInfo			85.7%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:881:	getReqRegsInfo				100.0%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:890:	getReqGeoInfo				100.0%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:902:	getReqConsentInfo			80.0%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:912:	unmarshalExtImpHuaweiAds		88.2%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:939:	checkRespStatusCode			77.8%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:962:	checkHuaweiAdsResponseRetcode		80.0%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:976:	convertHuaweiAdsRespToBidderResp	90.2%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:1045:	getNurl					66.7%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:1058:	handleHuaweiAdsContent			87.5%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:1078:	extractAdmBanner			60.0%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:1100:	extractAdmNative			91.9%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:1220:	getDecodeValue				80.0%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:1231:	jsonEncode				100.0%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:1240:	extractAdmPicture			90.9%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:1303:	getClickUrl				100.0%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:1320:	getDspImpClickTrackings			100.0%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:1334:	getStrings				87.5%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:1349:	getDuration				100.0%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:1356:	extractAdmVideo				85.4%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:1519:	getVastImpClickErrorTrackingUrls	100.0%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:1539:	getVastEventTrackingUrls		100.0%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:1559:	computeHmacSha256			100.0%
github.com/prebid/prebid-server/adapters/huaweiads/huaweiads.go:1566:	getDigestAuthorization			100.0%
total:									(statements)				90.8%

@ahmetfaruk59 ahmetfaruk59 changed the title WIP: Ads huawei adapter HuaweiAds: Fixing the fill rate issue Oct 14, 2023
@ahmetfaruk59
Copy link
Contributor Author

@Sonali-More-Xandr Hi, could you please take a look, review changes?

@Sonali-More-Xandr Sonali-More-Xandr merged commit e8d93cc into prebid:master Oct 19, 2023
5 checks passed
svamiftah pushed a commit to sovrn/prebid-server that referenced this pull request Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants