HuaweiAds: Fixing the fill rate issue (prebid#3219)

sovrn · Nov 21, 2023 · dfa7fa7 · dfa7fa7
1 parent 73bd52c
commit dfa7fa7
Show file tree

Hide file tree

Showing 6 changed files with 22 additions and 2 deletions.
diff --git a/adapters/huaweiads/huaweiads.go b/adapters/huaweiads/huaweiads.go
@@ -536,7 +536,8 @@ func getNativeFormat(adslot30 *adslot30, openRTBImp *openrtb2.Imp) error {
 	// only compute the main image number, type = native1.ImageAssetTypeMain
 	var numMainImage = 0
 	var numVideo = 0
-
+	var width int64
+	var height int64
 	for _, asset := range nativePayload.Assets {
 		// Only one of the {title,img,video,data} objects should be present in each object.
 		if asset.Video != nil {
@@ -547,10 +548,19 @@ func getNativeFormat(adslot30 *adslot30, openRTBImp *openrtb2.Imp) error {
 		if asset.Img != nil {
 			if asset.Img.Type == native1.ImageAssetTypeMain {
 				numMainImage++
+				if asset.Img.H != 0 && asset.Img.W != 0 {
+					width = asset.Img.W
+					height = asset.Img.H
+				} else if asset.Img.WMin != 0 && asset.Img.HMin != 0 {
+					width = asset.Img.WMin
+					height = asset.Img.HMin
+				}
 			}
 			continue
 		}
 	}
+	adslot30.W = width
+	adslot30.H = height
 
 	var detailedCreativeTypeList = make([]string, 0, 2)
 	if numVideo >= 1 {

diff --git a/adapters/huaweiads/huaweiadstest/exemplary/nativeIncludeVideo.json b/adapters/huaweiads/huaweiadstest/exemplary/nativeIncludeVideo.json
@@ -95,6 +95,8 @@
               "detailedCreativeTypeList": [
                 "903"
               ],
+              "h": 200,
+              "w": 200,
               "test": 1
             }
           ],

diff --git a/adapters/huaweiads/huaweiadstest/exemplary/nativeSingleImage.json b/adapters/huaweiads/huaweiadstest/exemplary/nativeSingleImage.json
@@ -93,6 +93,8 @@
               "detailedCreativeTypeList": [
                 "901"
               ],
+              "h": 200,
+              "w": 200,
               "test": 1
             }
           ],

diff --git a/adapters/huaweiads/huaweiadstest/exemplary/nativeThreeImage.json b/adapters/huaweiads/huaweiadstest/exemplary/nativeThreeImage.json
@@ -92,6 +92,8 @@
               "detailedCreativeTypeList": [
                 "904"
               ],
+              "h": 200,
+              "w": 200,
               "test": 1
             }
           ],

diff --git a/adapters/huaweiads/huaweiadstest/exemplary/nativeThreeImageIncludeIcon.json b/adapters/huaweiads/huaweiadstest/exemplary/nativeThreeImageIncludeIcon.json
@@ -93,6 +93,8 @@
               "detailedCreativeTypeList": [
                 "904"
               ],
+              "h": 200,
+              "w": 200,
               "test": 1
             }
           ],

diff --git a/adapters/huaweiads/huaweiadstest/supplemental/bad_response_not_native.json b/adapters/huaweiads/huaweiadstest/supplemental/bad_response_not_native.json
@@ -93,7 +93,9 @@
               "test": 1,
               "detailedCreativeTypeList": [
                 "903"
-              ]
+              ],
+              "h": 200,
+              "w": 200
             }
           ],
           "device": {