Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HuaweiAds: Fixing the fill rate issue #3219

Merged
merged 6 commits into from
Oct 19, 2023
+22 −2
Merged

HuaweiAds: Fixing the fill rate issue #3219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b9fb570
fix cta text empty and fill rate issue
ahmetfaruk59 Sep 1, 2023
9a8d833
removed commented code.add cta instance to test
ahmetfaruk59 Sep 5, 2023
0407477
add type of cta text, edit test case for cta text
ahmetfaruk59 Sep 6, 2023
56d9348
Fix fill rate issue
ahmetfaruk59 Oct 14, 2023
59e2b48
Merge branch 'master' into adsHuaweiAdapter
ahmetfaruk59 Oct 14, 2023
44940f4
Fix fill rate issue
ahmetfaruk59 Oct 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion adapters/huaweiads/huaweiads.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -536,7 +536,8 @@ func getNativeFormat(adslot30 *adslot30, openRTBImp *openrtb2.Imp) error {
// only compute the main image number, type = native1.ImageAssetTypeMain
var numMainImage = 0
var numVideo = 0

var width int64
var height int64
for _, asset := range nativePayload.Assets {
// Only one of the {title,img,video,data} objects should be present in each object.
if asset.Video != nil {
Expand All @@ -547,10 +548,19 @@ func getNativeFormat(adslot30 *adslot30, openRTBImp *openrtb2.Imp) error {
if asset.Img != nil {
if asset.Img.Type == native1.ImageAssetTypeMain {
numMainImage++
if asset.Img.H != 0 && asset.Img.W != 0 {
width = asset.Img.W
height = asset.Img.H
} else if asset.Img.WMin != 0 && asset.Img.HMin != 0 {
width = asset.Img.WMin
height = asset.Img.HMin
}
}
continue
}
}
adslot30.W = width
adslot30.H = height

var detailedCreativeTypeList = make([]string, 0, 2)
if numVideo >= 1 {
Expand Down
2 changes: 2 additions & 0 deletions adapters/huaweiads/huaweiadstest/exemplary/nativeIncludeVideo.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,8 @@
"detailedCreativeTypeList": [
"903"
],
"h": 200,
"w": 200,
"test": 1
}
],
Expand Down
2 changes: 2 additions & 0 deletions adapters/huaweiads/huaweiadstest/exemplary/nativeSingleImage.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,8 @@
"detailedCreativeTypeList": [
"901"
],
"h": 200,
"w": 200,
"test": 1
}
],
Expand Down
2 changes: 2 additions & 0 deletions adapters/huaweiads/huaweiadstest/exemplary/nativeThreeImage.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,8 @@
"detailedCreativeTypeList": [
"904"
],
"h": 200,
"w": 200,
"test": 1
}
],
Expand Down
2 changes: 2 additions & 0 deletions adapters/huaweiads/huaweiadstest/exemplary/nativeThreeImageIncludeIcon.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,8 @@
"detailedCreativeTypeList": [
"904"
],
"h": 200,
"w": 200,
"test": 1
}
],
Expand Down
4 changes: 3 additions & 1 deletion adapters/huaweiads/huaweiadstest/supplemental/bad_response_not_native.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,9 @@
"test": 1,
"detailedCreativeTypeList": [
"903"
]
],
"h": 200,
"w": 200
}
],
"device": {
Expand Down
Loading