Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FEC-14080): Accessibility fix for the top bar and the bottom bar #790

Merged
merged 4 commits into from
Aug 29, 2024

Conversation

SivanA-Kaltura
Copy link
Contributor

@SivanA-Kaltura SivanA-Kaltura commented Aug 25, 2024

Description of the Changes

Append a div to be used by the ui when displaying a player gradient.
This way, the gradient is stacked in the z coordinate above the player but below everything else.

Related PRs:
kaltura/playkit-js-ui#925
kaltura/playkit-js-dual-screen#150

Resolves FEC-14080

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

src/player.ts Show resolved Hide resolved
@SivanA-Kaltura SivanA-Kaltura merged commit 84824f4 into master Aug 29, 2024
11 checks passed
SivanA-Kaltura added a commit that referenced this pull request Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants