fix(FEC-14080): Accessibility fix for the top bar and the bottom bar #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 25, 2024
Merged
SivanA-Kaltura
requested review from
semarche-kaltura,
lianbenjamin and
MosheMaorKaltura
lianbenjamin
requested changes
Aug 26, 2024
src/styles/global.scss
Outdated
| display: none; | ||
| } | ||
|
|
||
| &:after { |
There was a problem hiding this comment.
can the before and after be shorten? since they are the same
| @@ -22,7 +22,12 @@ export class PipParent extends Component<PIPParentComponentProps> { | |||
|
|
|||
| componentDidMount() { | |||
| const {player} = this.props; | |||
|
|
|||
| const videoFilter = document.createElement('div'); | |||
There was a problem hiding this comment.
not a critical one, but since player applying the same styles we can move creation and appending element into ui.utils
| @@ -5,4 +5,13 @@ | |||
| :global(.playkit-slideIn) { | |||
| z-index: 1; | |||
| } | |||
| :global(.playkit-container .playkit-video-filter) { | |||
There was a problem hiding this comment.
probably we can use utility from ui to manage video-filter node (add/remove)
semarche-kaltura
approved these changes
Sep 3, 2024
lianbenjamin
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
Append a playkit-video-filter div next to the player the same way that playkit does, since the playkit-video-filter from playkit is displayed incorrectly when dualscreen is active
Also upgraded cypress to resolve Firefox timeout
Related PRs:
kaltura/playkit-js#790
kaltura/playkit-js-ui#925
Resolves FEC-14080