Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FEC-14080): Accessibility fix for the top bar and the bottom bar #790

Merged
merged 4 commits into from
Aug 29, 2024
Merged

fix(FEC-14080): Accessibility fix for the top bar and the bottom bar #790

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3af730d
append playkit-video-filter element
SivanA-Kaltura Aug 21, 2024
85bf217
remove unused line
SivanA-Kaltura Aug 26, 2024
b27ad14
remove auto indent
SivanA-Kaltura Aug 26, 2024
e11596f
remove auto format
SivanA-Kaltura Aug 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/player.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,14 @@ const CONTAINER_CLASS_NAME: string = 'playkit-container';
*/
const POSTER_CLASS_NAME: string = 'playkit-poster';

/**
lianbenjamin marked this conversation as resolved.
Show resolved Hide resolved
/**
* The video filter class name.
* @type {string}
* @const
*/
const VIDEO_FILTER_CLASS_NAME: string = 'playkit-video-filter';

/**
* The engine class name.
* @type {string}
Expand Down Expand Up @@ -1803,6 +1811,10 @@ export default class Player extends FakeEventTarget {
* @returns {void}
*/
private _appendDomElements(): void {
// Append playkit-video-filter
const videoFilter = Utils.Dom.createElement('div');
Utils.Dom.addClassName(videoFilter, VIDEO_FILTER_CLASS_NAME);
Utils.Dom.appendChild(this._el, videoFilter);
// Append playkit-black-cover
this._blackCoverEl = Utils.Dom.createElement('div');
Utils.Dom.addClassName(this._blackCoverEl, BLACK_COVER_CLASS_NAME);
Expand Down
Loading