fix(ADA-1612): Removed generic role #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RazvanBrinzoiK05
requested review from
MosheMaorKaltura,
semarche-kaltura,
lianbenjamin and
SivanA-Kaltura
semarche-kaltura
requested changes
Sep 4, 2024
|
Updated the PR with the common repo version |
semarche-kaltura
requested changes
Sep 19, 2024
semarche-kaltura
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With:
kaltura/playkit-js-common#61
Issue:
Generic role is for use by user agents and not by developers, so it must be removed
Fix:
Providing null as a valid prop that will remove the role attribute making the html element generic without developer intervention that can be detected in the developer console.