fix(ADA-1612): Option to remove role that is set by default (Based on v1.2.10) #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RazvanBrinzoiK05
requested review from
MosheMaorKaltura,
semarche-kaltura,
lianbenjamin and
SivanA-Kaltura
semarche-kaltura
approved these changes
Sep 4, 2024
RazvanBrinzoiK05
added a commit
to kaltura/playkit-js-ui-managers
that referenced
this pull request
Sep 26, 2024
With: kaltura/playkit-js-common#61 Issue: Generic role is for use by user agents and not by developers, so it must be removed Fix: Providing null as a valid prop that will remove the role attribute making the html element generic without developer intervention that can be detected in the developer console.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With:
kaltura/playkit-js-ui-managers#62
Issue:
Generic role is for use by user agents and not by developers, so we must provide an option to remove the default role for this component.
The fix was added for playkit-js-ui-managers icon wrappers. That repo uses v1.2.10 version of this repo
Fix:
Providing null as a valid prop that will remove the role attribute making the html element generic without developer intervention that can be detected in the developer console.