Skip to content

Commit

Permalink
fix(ADA-1612): Removed generic role (#62)
Browse files Browse the repository at this point in the history
With:
kaltura/playkit-js-common#61

Issue:
Generic role is for use by user agents and not by developers, so it must
be removed

Fix:
Providing null as a valid prop that will remove the role attribute
making the html element generic without developer intervention that can
be detected in the developer console.
  • Loading branch information
RazvanBrinzoiK05 authored Sep 26, 2024
1 parent 3b2567a commit 1c8c3ae
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 18 deletions.
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,9 @@
"@types/node": "^14.11.2",
"@typescript-eslint/eslint-plugin": "^5.25.0",
"@typescript-eslint/parser": "^5.25.0",
"conventional-github-releaser": "3.1.3",
"babel-loader": "^8.2.4",
"chai": "^4.3.6",
"conventional-github-releaser": "3.1.3",
"css-loader": "^6.7.1",
"eslint": "^7.32.0",
"eslint-config-preact": "^1.3.0",
Expand Down Expand Up @@ -104,6 +104,6 @@
"name": "uiManagers"
},
"dependencies": {
"@playkit-js/common": "^1.2.10"
"@playkit-js/common": "1.5.18"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ type IconWrapperProps = {
export class IconWrapper extends Component<IconWrapperProps> {
render(): ComponentChild {
return (
<A11yWrapper role="generic" onClick={this.props.onClick}>
<A11yWrapper role={null} onClick={this.props.onClick}>
<div>{cloneElement(this.props.children as VNode)}</div>
</A11yWrapper>
);
Expand Down
19 changes: 4 additions & 15 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -1146,12 +1146,11 @@
"@nodelib/fs.scandir" "2.1.5"
fastq "^1.6.0"

"@playkit-js/common@^1.2.10":
version "1.2.10"
resolved "https://registry.yarnpkg.com/@playkit-js/common/-/common-1.2.10.tgz#c66edc706ae449689b53ccf342dc0eb9f18a9dbe"
integrity sha512-jmh08OLxizkddFH7m8w6UGkC5Z9GvIIsl3Ol5Vp2o5d00MvIRho8bUJISPR+ac0mQY/WarpbFm8iRQl7Kwo+oQ==
"@playkit-js/common@1.5.18":
version "1.5.18"
resolved "https://registry.npmjs.org/@playkit-js/common/-/common-1.5.18.tgz#eb9a895ebacb79a7285d86c45f3522f4c3a51b77"
integrity sha512-S7dSSBpfjajrHQ0tdpdStch2HmQS6Bl3tVJzJbz3lg54dcy3Uv9GwrfcpTztnlfdNh8iuzxfPEeTHXKWQU/lRA==
dependencies:
"@playkit-js/playkit-js-ui" "^0.77.1"
classnames "^2.3.2"
linkify-it "^4.0.1"

Expand Down Expand Up @@ -1197,16 +1196,6 @@
react-redux "^7.2.0"
redux "^4.0.5"

"@playkit-js/playkit-js-ui@^0.77.1":
version "0.77.1"
resolved "https://registry.yarnpkg.com/@playkit-js/playkit-js-ui/-/playkit-js-ui-0.77.1.tgz#1bb76f5ca8dd1ed3fd389cce818e2f454d3897a0"
integrity sha512-4ReI5oAmzUGkAKwRoRO+oy0fzpG+cgXOvGkWgZ/rjObjL2bpBIkHdmgTlAHsvrdKbBUfJThqdQwPsu8FkoQyVA==
dependencies:
preact "^10.3.4"
preact-i18n "^2.0.0-preactx.2"
react-redux "^7.2.0"
redux "^4.0.5"

"@playkit-js/playkit-js-ui@canary":
version "0.77.2-canary.0-ee0e6eb"
resolved "https://registry.yarnpkg.com/@playkit-js/playkit-js-ui/-/playkit-js-ui-0.77.2-canary.0-ee0e6eb.tgz#e39ca4c16b8588e58d72b919092dff9f01900ef5"
Expand Down

0 comments on commit 1c8c3ae

Please sign in to comment.