Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Typo] Fix typos #563

Merged
merged 1 commit into from
Oct 25, 2023
Merged

[Typo] Fix typos #563

merged 1 commit into from
Oct 25, 2023

Conversation

Li-Jinjie
Copy link
Contributor

What is this

Fix a typo: change the folder name /altmeter in /sensor to /altimeter
Fix a typo: change the frame NEU in a comment to ENU.

@Li-Jinjie
Copy link
Contributor Author

Fix 2 needs to be verified

@tongtybj tongtybj self-requested a review October 19, 2023 15:38
@Li-Jinjie Li-Jinjie changed the title Fix typos [Typo] Fix typos Oct 19, 2023
@tongtybj
Copy link
Collaborator

@Li-Jinjie

Can you eplain the meaning of Fix 2 needs to be verified?

@Li-Jinjie
Copy link
Contributor Author

@Li-Jinjie

Can you eplain the meaning of Fix 2 needs to be verified?

Yeah, the original text is NEU, so if we use right-hand coordination, the correct coordination system should be ENU or NED. I guess our coordinate system is ENU, but I still hope that you can make sure this.

@tongtybj
Copy link
Collaborator

I guess our coordinate system is ENU, but I still hope that you can make sure this.

Yes, you are right. It should be ENU.

ouster-lidar/ouster-sdk#13

@tongtybj tongtybj merged commit c367c7c into jsk-ros-pkg:master Oct 25, 2023
6 checks passed
@Li-Jinjie Li-Jinjie deleted the modify_typo branch October 26, 2023 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants