Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1311 products title metadata fix #1315

Merged
merged 3 commits into from
Dec 4, 2024
Merged

1311 products title metadata fix #1315

merged 3 commits into from
Dec 4, 2024

Conversation

Raja-danaher
Copy link
Collaborator

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix # 1311

Test URLs:

@Raja-danaher Raja-danaher linked an issue Dec 3, 2024 that may be closed by this pull request
[Products] Tab Tile should use the metadata title and not H1 #1311
Closed
@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Dec 3, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Dec 3, 2024 •
edited
Loading

Page Scores Audits Google
📱 /us/en/products/family/mica PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /us/en/products/family/mica PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

lakshmithi
lakshmithi approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@lakshmithi lakshmithi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed.

davenichols-DHLS
davenichols-DHLS approved these changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@davenichols-DHLS davenichols-DHLS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, looks like the tab etc is working, thanks.

@davenichols-DHLS davenichols-DHLS merged commit 0d4f2eb into main Dec 4, 2024
2 checks passed
@davenichols-DHLS davenichols-DHLS deleted the 1311-products-title-metadata-fix branch December 4, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lakshmithi lakshmithi lakshmithi approved these changes

@davenichols-DHLS davenichols-DHLS davenichols-DHLS approved these changes

@deepakk799 deepakk799 deepakk799 approved these changes

@rgravitvl rgravitvl Awaiting requested review from rgravitvl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Products] Tab Tile should use the metadata title and not H1
4 participants
@Raja-danaher @deepakk799 @davenichols-DHLS @lakshmithi