Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1311 products title metadata fix #1315

Merged
merged 3 commits into from
Dec 4, 2024
Merged

1311 products title metadata fix #1315

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
89bdd94
1311-products-title-metadata-fix
Raja-danaher Dec 3, 2024
10183e0
Update product-hero.js
Raja-danaher Dec 3, 2024
8e81273
Code update.
Raja-danaher Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion blocks/product-hero/product-hero.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,8 @@
titleEl?.parentElement.parentElement.remove();
const response = await getProductResponse();
if (response?.length > 0) {
document.title = response[0].Title ? response[0].Title : 'Danaher Product';
Raja-danaher marked this conversation as resolved.
Show resolved Hide resolved
//1311-products-title-metadata-fix

Check failure on line 171 in blocks/product-hero/product-hero.js

View workflow job for this annotation

GitHub Actions / build 

Expected exception block, space or tab after '//' in comment
//document.title = response[0].Title ? response[0].Title : 'Danaher Product';

Check failure on line 172 in blocks/product-hero/product-hero.js

View workflow job for this annotation

GitHub Actions / build 

Expected exception block, space or tab after '//' in comment
const allImages = response[0]?.raw.images;
const verticalImageGallery = imageSlider(allImages, response[0]?.Title);
const defaultContent = div();
Expand Down
Loading