Add references to kinesisanalyticsv2.Application #1039
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbbush
requested review from
ulucinar,
sergenyalcin and
turkenf
as code owners
mbbush
force-pushed
the
kinesisanalyticsv2/references
branch
3 times, most recently
from
f73bfba to
075e65c
Compare
1 task
mbbush
force-pushed
the
kinesisanalyticsv2/references
branch
from
075e65c to
2867c77
Compare
|
/test-examples="examples/kinesisanalyticsv2/application.yaml" |
|
/test-examples="examples/kinesisanalyticsv2/applicationsnapshot.yaml" |
|
/test-examples="examples/kinesisanalyticsv2/application.yaml" |
|
@mbbush, we have a release planned for Thursday, February 1st, please check uptest runs if you are still considering moving this PR forward. |
|
@turkenf I will rebase, rerun codegen, and rerun uptest, but I expect the tests to fail again on the import step for the |
mbbush
force-pushed
the
kinesisanalyticsv2/references
branch
from
9809706 to
7e34428
Compare
|
/test-examples="examples/kinesisanalyticsv2/v1beta1/application.yaml" |
|
/test-examples="examples/kinesisanalyticsv2/v1beta1/applicationsnapshot.yaml" |
|
Run https://github.com/upbound/provider-aws/actions/runs/7745911112/job/21122975155 would have passed if not for #978, and will pass once provider-aws consumes the latest changes from uptest. Here's the final manifest before it times out: |
|
/test-examples="examples/kinesisanalyticsv2/v1beta1/applicationsnapshot.yaml" |
Signed-off-by: Matt Bush <[email protected]>
…alyticsv2 Signed-off-by: Matt Bush <[email protected]>
Signed-off-by: Matt Bush <[email protected]>
Signed-off-by: Matt Bush <[email protected]>
mbbush
force-pushed
the
kinesisanalyticsv2/references
branch
from
7e34428 to
169cd66
Compare
Signed-off-by: Matt Bush <[email protected]>
|
/test-examples="examples/kinesisanalyticsv2/v1beta1/application.yaml" |
|
We can continue this PR by sharing the manual test results without waiting for the uptest to be successful, @mbbush. Maybe if the uptests of the existing examples pass successfully, we can add new example manifests with the references you added and add manual intervention to them, what do you think? |
|
This provider repo does not have enough maintainers to address every pull request. Since there has been no activity in the last 90 days it is now marked as |
|
This pull request is being closed since there has been no activity for 14 days since marking it as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
kinesisanalyticsv2was renamed without thevI have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
With uptest. The test runs in the cloud fail on the import step because of #978, but otherwise pass. I checked the logs from https://github.com/upbound/provider-aws/actions/runs/7745911112/job/21122975155 (application) confirmed there were no other issues besides the id change on the Object.s3 resource. The applicationsnapshot test failed because the aws account for uptest hit a limit on the maximum number of VPCs. I'm rerunning it.
I opened upbound/official-providers-ci#173 to add functionality to uptest to allow skipping the same-id check on a per-resource basis, and when I run that version of uptest locally, both
application.yamlandapplicationsnapshot.yamlpass completely.