Skip import id-check step on non-root resources #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add defer statment to remove all test directory before completing the cases Signed-off-by: Sergen Yalçın <[email protected]>
1 task
|
@mbbush PR looks good to me. After you resolve conflicts, I will approve the PR. |
|
@sergenyalcin Conflicts resolved. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
I expanded on @sergenyalcin's work in #170 and added the ability to place the
uptest.upbound.io/disable-import: "true"on a non-root resource, which makes the import step still run, but omit that resource from the check that the new resources have the same id.This allows the use of examples containing e.g. Object.s3.aws.upbound.io resources, for which the terraform provider returns a differently-formatted id depending on whether the resource is created or observed.
Fixes #
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
I used this to locally test crossplane-contrib/provider-upjet-aws#1039 successfully.
I added a new unit test, and it passes.