Kinesisanalytics typo fix #1014
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbbush
requested review from
ulucinar,
sergenyalcin and
turkenf
as code owners
mbbush
force-pushed
the
kinesisanalytics-typo-fix
branch
from
72e72a2 to
db4ae31
Compare
|
Thank you @mbbush, If it doesn't cause any API changes as far as I can see it doesn't, I don't see any problems moving this forward. |
|
/test-examples="examples/kinesisanalyticsv2/application.yaml" |
|
/test-examples="examples/kinesisanalyticsv2/applicationsnapshot.yaml" |
|
This commit is included in #1039, where I actually got the tests working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
I noticed that for some reason the kinesisanalyticsv2 package was named without the v, unlike all other packages. This seemed unnecessary, so I brought it in line with all the others.
There was no change to any of the generated code.
make check-diff testto validate that there's no diff in generated code and run unit tests. Linting is currently broken.How has this code been tested
If the maintainers agree with me that this is a non-breaking change, I'll run the e2e tests for the kinesisanalyticsv2 resources locally, since they require specific files uploaded to s3.