Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mechanism registration function for non POINT_PROCESSes #1111

Merged
merged 5 commits into from
Dec 5, 2023

Conversation

iomaganaris
Copy link
Contributor

@iomaganaris iomaganaris commented Dec 4, 2023

@iomaganaris iomaganaris added the NEURON codegen Work toward NEURON code generation label Dec 4, 2023
@iomaganaris iomaganaris requested a review from 1uc December 4, 2023 16:13
@iomaganaris iomaganaris self-assigned this Dec 4, 2023
@1uc
Copy link
Collaborator

1uc commented Dec 4, 2023

Is this enough to generate a special that compiles, links and runs, e.g. for:

NEURON {
    SUFFIX leonhard
}

STATE { x }

INITIAL {
  x = 42
}

BREAKPOINT {
    SOLVE dX METHOD cnexp
}

DERIVATIVE dX { x' = -0.1*x }

and

from neuron import h, gui
from neuron.units import ms, mV

nsec = 10
nseg = 20

sections = [h.Section() for _ in range(nsec)]
for s in sections:
    s.insert("leonhard")
    s.nseg = nseg

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6abad06) 88.18% compared to head (e93019b) 88.23%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1111      +/-   ##
==========================================
+ Coverage   88.18%   88.23%   +0.05%     
==========================================
  Files         175      175              
  Lines       12905    12949      +44     
==========================================
+ Hits        11380    11426      +46     
+ Misses       1525     1523       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bbpbuildbot

This comment has been minimized.

@iomaganaris
Copy link
Contributor Author

iomaganaris commented Dec 4, 2023

Is this enough to generate a special that compiles, links and runs, e.g. for:

NEURON {
    SUFFIX leonhard
}

STATE { x }

INITIAL {
  x = 42
}

BREAKPOINT {
    SOLVE dX METHOD cnexp
}

DERIVATIVE dX { x' = -0.1*x }

and

from neuron import h, gui
from neuron.units import ms, mV

nsec = 10
nseg = 20

sections = [h.Section() for _ in range(nsec)]
for s in sections:
    s.insert("leonhard")
    s.nseg = nseg

After a small fix yes. You can also try it yourself and let me know if there is any issue

@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #177237 (:white_check_mark:) have been uploaded here!

Status and direct links:

@1uc
Copy link
Collaborator

1uc commented Dec 5, 2023

I could have, but then I'd have had to make small fixes :)

@iomaganaris iomaganaris merged commit 7265ec9 into master Dec 5, 2023
18 checks passed
@iomaganaris iomaganaris deleted the magkanar/nmodl_reg_minimal branch December 5, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NEURON codegen Work toward NEURON code generation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants