Add more logic for POINT_PROCESS registration function

[iomaganaris]

• Added call to point_register_mech() needed for POINT_PROCESSes and related function definitions
• Added logic in nrn_alloc needed to create reasonable POINT_PROCESS tests
• Added test for POINT_PROCESS
• Added test for PARAMETER
• Added small logic for IONs as well in _<mech>_reg()
• Added small logic for diam as well in _<mech>_reg()

[codecov]

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (d1290e0) 88.16% compared to head (2cf0c02) 88.18%.

Files	Patch %	Lines
src/codegen/codegen_neuron_cpp_visitor.cpp	86.48%	15 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1106      +/-   ##
==========================================
+ Coverage   88.16%   88.18%   +0.02%     
==========================================
  Files         176      176              
  Lines       12684    12791     +107     
==========================================
+ Hits        11183    11280      +97     
- Misses       1501     1511      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[1uc]

This contains a lot of unrelated changes. Could we please split it:

1. Moving the code for CodegenCppVisitor::get_parameter_str.
2. Anything related to point-processes and the stuff found in CodegenNeuronCppVisitor::print_function_prototypes would be best studied in isolation.
3. The changes in print_sdlists_init superficially feel like bug fixes. If yes, separate PR.
4. The things related to getting {}_reg to work. This includes the extern "C" { change and things like register_mech_args and print_nrn_{state,jacob,...}`.

I'd think reviewing 4. first would be best, with 1. in parallel.

[iomaganaris]

This contains a lot of unrelated changes. Could we please split it:

1. Moving the code for CodegenCppVisitor::get_parameter_str.
2. Anything related to point-processes and the stuff found in CodegenNeuronCppVisitor::print_function_prototypes would be best studied in isolation.
3. The changes in print_sdlists_init superficially feel like bug fixes. If yes, separate PR.
4. The things related to getting {}_reg to work. This includes the extern "C" { change and things like register_mech_args and print_nrn_{state,jacob,...}`.

I'd think reviewing 4. first would be best, with 1. in parallel.

Right, I thought it would be better to get all the related parts of the code I touched together so I don't miss anything from NEURON but since it complicated things I created separated PRs.

1. Fixing function declarations #1109
2. In this PR
3. Refactor slist and dlist according to NEURON #1110
4. Fix mechanism registration function for non POINT_PROCESSes #1111

[ohm314]

looks good to me, had just one minor question

[pramodk]

Overall looks Ok. I have few comments+questions to clarify.

[pramodk]

Conflicting files
src/codegen/codegen_neuron_cpp_visitor.cpp

I am going to attempt git merge. Looking at the conflicts for the above, I guess its a punishment for not reviewing & merging on timely manner! 😄

[bbpbuildbot]

Logfiles from GitLab pipeline #192525 (:white_check_mark:) have been uploaded here!

Status and direct links:

• ✅ spack_setup
• ✅ build:intel
• ✅ build:nvhpc
• ✅ test:intel
• ✅ test:nvhpc

[pramodk]

I skimmed through the changes one more time and looked on NEURON's nocmodl side. Changes look reasonable.

As all tests passes, including existing ones, I am going to merge this.