Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stubs of nrn_{alloc,init,jacob,cur,state}. #1103

Closed
wants to merge 5 commits into from
Closed

Conversation

1uc
Copy link
Collaborator

@1uc 1uc commented Dec 1, 2023

No description provided.

Copy link
Contributor

@iomaganaris iomaganaris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor suggestions. I could also apply them in my next patch as well though

src/codegen/codegen_neuron_cpp_visitor.cpp Outdated Show resolved Hide resolved
src/codegen/codegen_neuron_cpp_visitor.cpp Outdated Show resolved Hide resolved
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5bae4d0) 88.18% compared to head (4c4b91d) 88.21%.

❗ Current head 4c4b91d differs from pull request most recent head 97d43f6. Consider uploading reports for the commit 97d43f6 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1103      +/-   ##
==========================================
+ Coverage   88.18%   88.21%   +0.03%     
==========================================
  Files         175      175              
  Lines       12905    12924      +19     
==========================================
+ Hits        11380    11401      +21     
+ Misses       1525     1523       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bbpbuildbot

This comment has been minimized.

@1uc 1uc force-pushed the 1uc/nrn_signatures branch from 3db99fb to 97d43f6 Compare December 1, 2023 15:19
@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #176666 (:no_entry:) have been uploaded here!

Status and direct links:

@iomaganaris
Copy link
Contributor

Done in #1111

@iomaganaris iomaganaris closed this Dec 6, 2023
@1uc 1uc deleted the 1uc/nrn_signatures branch July 12, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants