Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor slist and dlist according to NEURON #1110

Merged
merged 10 commits into from
Dec 7, 2023
Merged

Refactor slist and dlist according to NEURON #1110

merged 10 commits into from
Dec 7, 2023

Conversation

iomaganaris
Copy link
Contributor

No description provided.

@iomaganaris iomaganaris added the NEURON codegen Work toward NEURON code generation label Dec 4, 2023
@iomaganaris iomaganaris requested a review from 1uc December 4, 2023 15:52
@iomaganaris iomaganaris self-assigned this Dec 4, 2023
@iomaganaris iomaganaris mentioned this pull request Dec 4, 2023
Merged
@codecov Codecov
Copy link

codecov bot commented Dec 4, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7265ec9) 88.23% compared to head (c735717) 88.24%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1110   +/-   ##
=======================================
  Coverage   88.23%   88.24%           
=======================================
  Files         175      175           
  Lines       12951    12960    +9     
=======================================
+ Hits        11427    11436    +9     
  Misses       1524     1524

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bbpbuildbot

This comment has been minimized.

Sign in to view
@1uc
Copy link
Collaborator

1uc commented Dec 5, 2023

How did you check it roughly does what you want it to?

@bbpbuildbot

This comment has been minimized.

Sign in to view
@iomaganaris
Copy link
Contributor Author

How did you check it roughly does what you want it to?

I just compared the code generated between nocmodl and nmodl. To actually test this change we need to move forward with code generated for the solvers and find specific MOD files that use those variables

@bbpbuildbot

This comment has been minimized.

Sign in to view
@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #177954 (:white_check_mark:) have been uploaded here!

Status and direct links:

@iomaganaris iomaganaris merged commit 85b0dfc into master Dec 7, 2023
18 checks passed
@iomaganaris iomaganaris deleted the magkanar/refactor_sdlistsinit branch December 7, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1uc 1uc 1uc approved these changes

Assignees

@iomaganaris iomaganaris

Labels
NEURON codegen Work toward NEURON code generation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iomaganaris @bbpbuildbot @1uc