-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C16 - Spruce - Vange Spracklin #46
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -15,47 +15,78 @@ def __init__(self): | |||||
self.front = -1 | ||||||
self.rear = -1 | ||||||
self.size = 0 | ||||||
|
||||||
|
||||||
def enqueue(self, element): | ||||||
""" Adds an element to the Queue | ||||||
Raises a QueueFullException if all elements | ||||||
In the store are occupied | ||||||
returns None | ||||||
""" | ||||||
pass | ||||||
if self.front == -1: | ||||||
self.front = 0 | ||||||
self.rear = 0 | ||||||
elif self.size == self.buffer_size: | ||||||
raise QueueFullException('Queue is full') | ||||||
|
||||||
self.store[self.rear] = element | ||||||
self.rear = (self.rear + 1) % self.buffer_size | ||||||
self.size += 1 | ||||||
|
||||||
def dequeue(self): | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ✨ |
||||||
""" Removes and returns an element from the Queue | ||||||
Raises a QueueEmptyException if | ||||||
The Queue is empty. | ||||||
""" | ||||||
pass | ||||||
if self.size == 0: | ||||||
raise QueueEmptyException('The queue is empty') | ||||||
else: | ||||||
return_value = self.store[self.front] | ||||||
self.store[self.front] = None | ||||||
self.front = (self.front + 1) % self.buffer_size | ||||||
self.size -= 1 | ||||||
return return_value | ||||||
|
||||||
def front(self): | ||||||
""" Returns an element from the front | ||||||
of the Queue and None if the Queue | ||||||
is empty. Does not remove anything. | ||||||
""" | ||||||
pass | ||||||
if self.size == 0: | ||||||
None | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🤔 Looks like you forgot to return here. As it stands, you basically state the name of a literal
Suggested change
|
||||||
return self.store[self.front] | ||||||
|
||||||
|
||||||
def size(self): | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ✨ |
||||||
""" Returns the number of elements in | ||||||
The Queue | ||||||
""" | ||||||
pass | ||||||
return self.size | ||||||
|
||||||
def empty(self): | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ✨ |
||||||
""" Returns True if the Queue is empty | ||||||
And False otherwise. | ||||||
""" | ||||||
pass | ||||||
if self.size == 0: | ||||||
return True | ||||||
else: | ||||||
False | ||||||
|
||||||
def __str__(self): | ||||||
""" Returns the Queue in String form like: | ||||||
[3, 4, 7] | ||||||
Starting with the front of the Queue and | ||||||
ending with the rear of the Queue. | ||||||
""" | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ✨ |
||||||
pass | ||||||
strang = "" | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🤗 I'm not sure why, but having this variable named |
||||||
count = 0 | ||||||
next = self.front | ||||||
while count < self.size: | ||||||
strang = strang + str(self.store[next]) | ||||||
if count != self.size - 1: | ||||||
strang = strang + ", " | ||||||
count += 1 | ||||||
next = (next + 1) % self.buffer_size | ||||||
return "[" + strang + "]" |
Original file line number | Diff line number | Diff line change | ||
---|---|---|---|---|
|
@@ -12,7 +12,8 @@ def push(self, element): | |||
""" Adds an element to the top of the Stack. | ||||
Returns None | ||||
""" | ||||
pass | ||||
self.store.add_last(element) | ||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ✨ |
||||
return None | ||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Small style tip: If a function always returns
Suggested change
|
||||
|
||||
def pop(self): | ||||
""" Removes an element from the top | ||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ✨ |
||||
|
@@ -21,18 +22,30 @@ def pop(self): | |||
The Stack is empty. | ||||
returns None | ||||
""" | ||||
pass | ||||
if self.store.head == None: | ||||
return None | ||||
return self.store.remove_last() | ||||
# return None | ||||
|
||||
def empty(self): | ||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ✨ |
||||
""" Returns True if the Stack is empty | ||||
And False otherwise | ||||
""" | ||||
pass | ||||
return self.store.empty | ||||
|
||||
def __str__(self): | ||||
""" Returns the Stack in String form like: | ||||
[3, 4, 7] | ||||
Starting with the top of the Stack and | ||||
ending with the bottom of the Stack. | ||||
""" | ||||
pass | ||||
if self.empty: | ||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ✨ Nice! You could also take advantage of |
||||
return "[]" | ||||
else: | ||||
values = [] | ||||
current = self.store.head | ||||
while current.next: | ||||
values.append(str(current.value)) | ||||
current = current.next | ||||
da_string = ", ".join(values) | ||||
return "[" + da_string + "]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨