Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C16 - Spruce - Vange Spracklin #46

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion stacks_queues/linked_list.py
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ def remove_first(self):


def empty(self):
return not self.head
return not self.head

# method to find if the linked list contains a node with specified value
# returns true if found, false otherwise
Expand Down
41 changes: 36 additions & 5 deletions stacks_queues/queue.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,47 +15,78 @@ def __init__(self):
self.front = -1
self.rear = -1
self.size = 0


def enqueue(self, element):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

""" Adds an element to the Queue
Raises a QueueFullException if all elements
In the store are occupied
returns None
"""
pass
if self.front == -1:
self.front = 0
self.rear = 0
elif self.size == self.buffer_size:
raise QueueFullException('Queue is full')

self.store[self.rear] = element
self.rear = (self.rear + 1) % self.buffer_size
self.size += 1

def dequeue(self):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

""" Removes and returns an element from the Queue
Raises a QueueEmptyException if
The Queue is empty.
"""
pass
if self.size == 0:
raise QueueEmptyException('The queue is empty')
else:
return_value = self.store[self.front]
self.store[self.front] = None
self.front = (self.front + 1) % self.buffer_size
self.size -= 1
return return_value

def front(self):
""" Returns an element from the front
of the Queue and None if the Queue
is empty. Does not remove anything.
"""
pass
if self.size == 0:
None

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 Looks like you forgot to return here. As it stands, you basically state the name of a literal None and then it floats away into the ether ☁

Suggested change
None
return None

return self.store[self.front]


def size(self):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

""" Returns the number of elements in
The Queue
"""
pass
return self.size

def empty(self):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

""" Returns True if the Queue is empty
And False otherwise.
"""
pass
if self.size == 0:
return True
else:
False

def __str__(self):
""" Returns the Queue in String form like:
[3, 4, 7]
Starting with the front of the Queue and
ending with the rear of the Queue.
"""

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pass
strang = ""

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤗 I'm not sure why, but having this variable named strang brings me a lot of joy

count = 0
next = self.front
while count < self.size:
strang = strang + str(self.store[next])
if count != self.size - 1:
strang = strang + ", "
count += 1
next = (next + 1) % self.buffer_size
return "[" + strang + "]"
21 changes: 17 additions & 4 deletions stacks_queues/stack.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@ def push(self, element):
""" Adds an element to the top of the Stack.
Returns None
"""
pass
self.store.add_last(element)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return None

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small style tip: If a function always returns None, I'd recommend returning None implicitly by just not having any return value (functions in Python return None by default).

Suggested change
return None


def pop(self):
""" Removes an element from the top

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expand All @@ -21,18 +22,30 @@ def pop(self):
The Stack is empty.
returns None
"""
pass
if self.store.head == None:
return None
return self.store.remove_last()
# return None

def empty(self):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

""" Returns True if the Stack is empty
And False otherwise
"""
pass
return self.store.empty

def __str__(self):
""" Returns the Stack in String form like:
[3, 4, 7]
Starting with the top of the Stack and
ending with the bottom of the Stack.
"""
pass
if self.empty:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ Nice! You could also take advantage of LinkedList's str method!

return "[]"
else:
values = []
current = self.store.head
while current.next:
values.append(str(current.value))
current = current.next
da_string = ", ".join(values)
return "[" + da_string + "]"