C16 - Spruce - Vange Spracklin #46
Conversation
There was a problem hiding this comment.
✨😎 Very nice work, Vange! I left a couple small suggestions, but overall your implementation is solid.
I am grading this as a yellow because you did not attempt the comprehension questions, but a yellow is a passing score. If you would like to resubmit with the comprehension questions filled in, I'd happily up this to a green!
🟡
| @@ -15,47 +15,78 @@ def __init__(self): | |||
| self.front = -1 | |||
| self.rear = -1 | |||
| self.size = 0 | |||
|
|
|||
|
|
|||
| def enqueue(self, element): | |||
|
|
||
| self.store[self.rear] = element | ||
| self.rear = (self.rear + 1) % self.buffer_size | ||
| self.size += 1 | ||
|
|
||
| def dequeue(self): |
|
|
||
| def front(self): | ||
| """ Returns an element from the front | ||
| of the Queue and None if the Queue | ||
| is empty. Does not remove anything. | ||
| """ | ||
| pass | ||
| if self.size == 0: | ||
| None |
There was a problem hiding this comment.
🤔 Looks like you forgot to return here. As it stands, you basically state the name of a literal None and then it floats away into the ether ☁
| None | |
| return None |
|
|
||
| def front(self): | ||
| """ Returns an element from the front | ||
| of the Queue and None if the Queue | ||
| is empty. Does not remove anything. | ||
| """ | ||
| pass | ||
| if self.size == 0: | ||
| None | ||
| return self.store[self.front] | ||
|
|
||
|
|
||
| def size(self): |
|
|
||
|
|
||
| def size(self): | ||
| """ Returns the number of elements in | ||
| The Queue | ||
| """ | ||
| pass | ||
| return self.size | ||
|
|
||
| def empty(self): |
| @@ -12,7 +12,8 @@ def push(self, element): | |||
| """ Adds an element to the top of the Stack. | |||
| Returns None | |||
| """ | |||
| pass | |||
| self.store.add_last(element) | |||
| @@ -12,7 +12,8 @@ def push(self, element): | |||
| """ Adds an element to the top of the Stack. | |||
| Returns None | |||
| """ | |||
| pass | |||
| self.store.add_last(element) | |||
| return None | |||
There was a problem hiding this comment.
Small style tip: If a function always returns None, I'd recommend returning None implicitly by just not having any return value (functions in Python return None by default).
| return None |
| @@ -12,7 +12,8 @@ def push(self, element): | |||
| """ Adds an element to the top of the Stack. | |||
| Returns None | |||
| """ | |||
| pass | |||
| self.store.add_last(element) | |||
| return None | |||
|
|
|||
| def pop(self): | |||
| """ Removes an element from the top | |||
| if self.store.head == None: | ||
| return None | ||
| return self.store.remove_last() | ||
| # return None | ||
|
|
||
| def empty(self): |
|
|
||
| def __str__(self): | ||
| """ Returns the Stack in String form like: | ||
| [3, 4, 7] | ||
| Starting with the top of the Stack and | ||
| ending with the bottom of the Stack. | ||
| """ | ||
| pass | ||
| if self.empty: |
There was a problem hiding this comment.
✨ Nice! You could also take advantage of LinkedList's str method!
Stacks and Queues
Thanks for doing some brain yoga. You are now submitting this assignment!
Comprehension Questions
OPTIONAL JobSimulation