Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow querying QualityManager supported qualities (#74) #91

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

nickurak
Copy link
Contributor

@nickurak nickurak commented Dec 4, 2023

This supports operations like scanning existing qualities and adding some related (modified) versions of them.

@nickurak
Copy link
Contributor Author

nickurak commented Dec 4, 2023

I'm exposing this (copied) dict via a function call rather than an attribute, to make sure the underlying immutable quality list doesn't get exposed in a writable way.

This supports operations like scanning existing qualities and adding
some related (modified) versions of them.
@nickurak nickurak force-pushed the add_quality_iteration branch from a6e2058 to dc1e748 Compare December 4, 2023 01:38
@nickurak
Copy link
Contributor Author

nickurak commented Dec 4, 2023

(force-push corrected some flake8 issues)

@yuma-m
Copy link
Owner

yuma-m commented Dec 4, 2023

@nickurak Thank you for your contribution. Your changes look good to me.

@yuma-m yuma-m merged commit e0ce1f4 into yuma-m:main Dec 4, 2023
6 checks passed
@yuma-m yuma-m linked an issue Dec 4, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to iterate qualities in Quality Manager
2 participants