Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to iterate qualities in Quality Manager #74

Closed
nickurak opened this issue Feb 20, 2022 · 1 comment · Fixed by #91
Closed

Ability to iterate qualities in Quality Manager #74

nickurak opened this issue Feb 20, 2022 · 1 comment · Fixed by #91

Comments

@nickurak
Copy link
Contributor

It'd be nice to be able to iterate what qualities pychord supports.

My specific use case is that I'm scanning existing qualities, and adding some related ones, specifically a no-5th and flat-5th variation on existing qualities.

Right now I have to peek inside QualityManager()._qualities to do that, which works, but is accessing a protected member, which is a little gross.

@yuma-m
Copy link
Owner

yuma-m commented Feb 21, 2022

Hi @nickurak, thank you for your comment. How about adding qualities property to the QualityManager class?
It will work like this. Would you create a pull request? Or I can make this change.

for quality, components in QualityManager().qualities.items():
    print(quality, components)

nickurak pushed a commit to nickurak/pychord that referenced this issue Dec 4, 2023
This supports operations like scanning existing qualities and adding
some related (modified) versions of them.
nickurak pushed a commit to nickurak/pychord that referenced this issue Dec 4, 2023
This supports operations like scanning existing qualities and adding
some related (modified) versions of them.
yuma-m pushed a commit that referenced this issue Dec 4, 2023
This supports operations like scanning existing qualities and adding
some related (modified) versions of them.

Co-authored-by: Jeremy Nickurak <[email protected]>
@yuma-m yuma-m linked a pull request Dec 4, 2023 that will close this issue
@yuma-m yuma-m closed this as completed Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants