Skip to content

Commit

Permalink
Fix CI. (#3727)
Browse files Browse the repository at this point in the history
  • Loading branch information
finnbear authored Sep 15, 2024
1 parent 15ac51c commit 4da1263
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 2 deletions.
2 changes: 1 addition & 1 deletion packages/yew-macro/src/derive_props/field.rs
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ impl PropField {
props_name: &'a Ident,
vis: &'a Visibility,
token: &'a GenericParam,
) -> PropFieldCheck<'_> {
) -> PropFieldCheck<'a> {
let check_struct = self.to_check_name(props_name);
let check_arg = self.to_check_arg_name(props_name);
PropFieldCheck {
Expand Down
1 change: 1 addition & 0 deletions packages/yew/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -295,6 +295,7 @@ mod renderer;

#[cfg(feature = "csr")]
#[cfg(test)]
#[allow(missing_docs)]
pub mod tests;

/// The module that contains all events available in the framework.
Expand Down
2 changes: 2 additions & 0 deletions packages/yew/src/tests/layout_tests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,14 @@ impl Component for Comp {
}

#[derive(Debug)]
#[allow(missing_docs)]
pub struct TestLayout<'a> {
pub name: &'a str,
pub node: VNode,
pub expected: &'a str,
}

#[allow(missing_docs)]
pub fn diff_layouts(layouts: Vec<TestLayout<'_>>) {
let document = gloo::utils::document();
let scope: AnyScope = AnyScope::test();
Expand Down
1 change: 1 addition & 0 deletions packages/yew/src/tests/mod.rs
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
#[allow(missing_docs)]
pub mod layout_tests;
2 changes: 1 addition & 1 deletion tools/website-test/build.rs
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ impl Level {

fn write_into(&self, dst: &mut String, name: &str, level: usize) -> fmt::Result {
self.write_space(dst, level);
let name = name.replace(|c| c == '-' || c == '.', "_");
let name = name.replace(['-', '.'], "_");
writeln!(dst, "pub mod {name} {{")?;

self.write_inner(dst, level + 1)?;
Expand Down

1 comment on commit 4da1263

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yew master branch benchmarks (Lower is better)

Benchmark suite Current: 4da1263 Previous: 15ac51c Ratio
yew-hooks-v0.21.0-keyed 01_run1k 195.2 201.5 0.97
yew-hooks-v0.21.0-keyed 02_replace1k 220.8 222.3 0.99
yew-hooks-v0.21.0-keyed 03_update10th1k_x16 87.3 93 0.94
yew-hooks-v0.21.0-keyed 04_select1k 39.8 41.3 0.96
yew-hooks-v0.21.0-keyed 05_swap1k 104.7 101.3 1.03
yew-hooks-v0.21.0-keyed 06_remove-one-1k 77.3 79.7 0.97
yew-hooks-v0.21.0-keyed 07_create10k 2225.6 2263.5 0.98
yew-hooks-v0.21.0-keyed 08_create1k-after1k_x2 229.5 232.9 0.99
yew-hooks-v0.21.0-keyed 09_clear1k_x8 87.9 90.2 0.97
yew-hooks-v0.21.0-keyed 21_ready-memory 2.1427040100097656 2.11441421508789 1.01
yew-hooks-v0.21.0-keyed 22_run-memory 6.304450988769531 6.304100036621094 1.00
yew-hooks-v0.21.0-keyed 23_update5-memory 6.605003356933594 6.535499572753906 1.01
yew-hooks-v0.21.0-keyed 25_run-clear-memory 5.142155647277832 5.143876075744629 1.00
yew-hooks-v0.21.0-keyed 26_run-10k-memory 42.80451202392578 42.804222106933594 1.00
yew-hooks-v0.21.0-keyed 41_size-uncompressed 168.3 168.3 1
yew-hooks-v0.21.0-keyed 42_size-compressed 54.6 54.6 1
yew-hooks-v0.21.0-keyed 43_first-paint 464.1 426.3 1.09
yew-v0.21.0-keyed 01_run1k 195.1 196.9 0.99
yew-v0.21.0-keyed 02_replace1k 212.8 223.3 0.95
yew-v0.21.0-keyed 03_update10th1k_x16 66.8 68.9 0.97
yew-v0.21.0-keyed 04_select1k 15.3 16.3 0.94
yew-v0.21.0-keyed 05_swap1k 79 80.4 0.98
yew-v0.21.0-keyed 06_remove-one-1k 68.7 67.5 1.02
yew-v0.21.0-keyed 07_create10k 2232 2252.2 0.99
yew-v0.21.0-keyed 08_create1k-after1k_x2 221.5 224 0.99
yew-v0.21.0-keyed 09_clear1k_x8 83.7 88.3 0.95
yew-v0.21.0-keyed 21_ready-memory 2.144887924194336 2.1250972747802734 1.01
yew-v0.21.0-keyed 22_run-memory 6.241277694702148 6.24113655090332 1.00
yew-v0.21.0-keyed 23_update5-memory 6.353899955749512 6.336615562438965 1.00
yew-v0.21.0-keyed 25_run-clear-memory 4.575557708740234 5.007468223571777 0.91
yew-v0.21.0-keyed 26_run-10k-memory 41.53852367401123 41.5703182220459 1.00
yew-v0.21.0-keyed 41_size-uncompressed 166.2 166.2 1
yew-v0.21.0-keyed 42_size-compressed 54.5 54.5 1
yew-v0.21.0-keyed 43_first-paint 452.4 446.6 1.01

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.