Skip to content

Commit

Permalink
Fix hidden files not being uploaded with actions/upload-artifact upgr…
Browse files Browse the repository at this point in the history
…ade in #3576 (#3724)

It was not prominently explained that "hidden" files, i.e. starting with "." are now ignored
this is only a problem when uploading globbed directories in benchmark where we don't
know the full path by default
  • Loading branch information
WorldSEnder authored Sep 5, 2024
1 parent e9d80ae commit 15ac51c
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/benchmark.yml
Original file line number Diff line number Diff line change
Expand Up @@ -136,3 +136,5 @@ jobs:
name: results
path: artifacts/
if-no-files-found: error
include-hidden-files: true
retention-days: 1

1 comment on commit 15ac51c

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yew master branch benchmarks (Lower is better)

Benchmark suite Current: 15ac51c Previous: 1f1c5c2 Ratio
yew-hooks-v0.21.0-keyed 01_run1k 201.5 197.1 1.02
yew-hooks-v0.21.0-keyed 02_replace1k 222.3 223 1.00
yew-hooks-v0.21.0-keyed 03_update10th1k_x16 93 97 0.96
yew-hooks-v0.21.0-keyed 04_select1k 41.3 40.6 1.02
yew-hooks-v0.21.0-keyed 05_swap1k 101.3 106 0.96
yew-hooks-v0.21.0-keyed 06_remove-one-1k 79.7 81.2 0.98
yew-hooks-v0.21.0-keyed 07_create10k 2263.5 2224.2 1.02
yew-hooks-v0.21.0-keyed 08_create1k-after1k_x2 232.9 236.5 0.98
yew-hooks-v0.21.0-keyed 09_clear1k_x8 90.2 93.3 0.97
yew-hooks-v0.21.0-keyed 21_ready-memory 2.11441421508789 2.1434097290039062 0.99
yew-hooks-v0.21.0-keyed 22_run-memory 6.304100036621094 6.268768310546875 1.01
yew-hooks-v0.21.0-keyed 23_update5-memory 6.535499572753906 6.602245330810547 0.99
yew-hooks-v0.21.0-keyed 25_run-clear-memory 5.143876075744629 5.147319793701172 1.00
yew-hooks-v0.21.0-keyed 26_run-10k-memory 42.804222106933594 42.81913471221924 1.00
yew-hooks-v0.21.0-keyed 41_size-uncompressed 168.3 168.4 1.00
yew-hooks-v0.21.0-keyed 42_size-compressed 54.6 54.5 1.00
yew-hooks-v0.21.0-keyed 43_first-paint 426.3 422.7 1.01
yew-v0.21.0-keyed 01_run1k 196.9 196.4 1.00
yew-v0.21.0-keyed 02_replace1k 223.3 223.1 1.00
yew-v0.21.0-keyed 03_update10th1k_x16 68.9 72.5 0.95
yew-v0.21.0-keyed 04_select1k 16.3 17.2 0.95
yew-v0.21.0-keyed 05_swap1k 80.4 84 0.96
yew-v0.21.0-keyed 06_remove-one-1k 67.5 68.8 0.98
yew-v0.21.0-keyed 07_create10k 2252.2 2259.5 1.00
yew-v0.21.0-keyed 08_create1k-after1k_x2 224 226 0.99
yew-v0.21.0-keyed 09_clear1k_x8 88.3 86.4 1.02
yew-v0.21.0-keyed 21_ready-memory 2.1250972747802734 2.081705093383789 1.02
yew-v0.21.0-keyed 22_run-memory 6.24113655090332 6.216424942016602 1.00
yew-v0.21.0-keyed 23_update5-memory 6.336615562438965 6.335565567016602 1.00
yew-v0.21.0-keyed 25_run-clear-memory 5.007468223571777 4.994392395019531 1.00
yew-v0.21.0-keyed 26_run-10k-memory 41.5703182220459 41.544328689575195 1.00
yew-v0.21.0-keyed 41_size-uncompressed 166.2 166.1 1.00
yew-v0.21.0-keyed 42_size-compressed 54.5 54.3 1.00
yew-v0.21.0-keyed 43_first-paint 446.6 418.3 1.07

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.