Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Terminate sub processes at exit #119

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

codingl2k1
Copy link
Contributor

@codingl2k1 codingl2k1 commented Dec 7, 2024

What do these changes do?

  • Make sure the driver process not hang at waiting for the subprocesses.

Related issue number

Fixes #xxxx

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass

@XprobeBot XprobeBot added the bug Something isn't working label Dec 7, 2024
@XprobeBot XprobeBot added this to the epic milestone Dec 7, 2024
@codingl2k1 codingl2k1 changed the title BUG: Make sub process deamon BUG: Terminate sub processes at exit Dec 7, 2024
Copy link

codecov bot commented Dec 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.67%. Comparing base (d6465c9) to head (c16b579).
Report is 24 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #119      +/-   ##
==========================================
- Coverage   88.97%   84.67%   -4.31%     
==========================================
  Files          48       53       +5     
  Lines        4038     4660     +622     
  Branches      770      509     -261     
==========================================
+ Hits         3593     3946     +353     
- Misses        358      611     +253     
- Partials       87      103      +16     
Flag Coverage Δ
unittests 84.46% <ø> (-4.35%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@luweizheng luweizheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codingl2k1 codingl2k1 merged commit a30e253 into xorbitsai:main Dec 12, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants