Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch: mocktr181 returns 520 for unsupported commands #195

Merged

Conversation

denopink
Copy link
Contributor

@denopink denopink commented Jul 16, 2024

  • mocktr181 currently only supports set and get commands, return 520 for any other commands

@denopink denopink added the enhancement improvement or small functionality added to an existing feature label Jul 16, 2024
@denopink denopink requested review from schmidtw and piccione99 July 16, 2024 02:05
@denopink denopink self-assigned this Jul 16, 2024
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.79%. Comparing base (a22907f) to head (95f2a20).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #195      +/-   ##
==========================================
- Coverage   76.85%   76.79%   -0.07%     
==========================================
  Files          75       75              
  Lines        4510     4511       +1     
==========================================
- Hits         3466     3464       -2     
- Misses        842      846       +4     
+ Partials      202      201       -1     
Flag Coverage Δ
unittests 76.79% <100.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- mocktr181 currently only supports `set` and `get` commands
@denopink denopink force-pushed the denopink/patch/mocktr181-return-520-for-unsupported-command branch from d991dcc to 95f2a20 Compare July 16, 2024 02:11
@schmidtw schmidtw merged commit 7cfc425 into main Jul 16, 2024
18 of 19 checks passed
@schmidtw schmidtw deleted the denopink/patch/mocktr181-return-520-for-unsupported-command branch July 16, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improvement or small functionality added to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants