patch: mocktr181 returns 520 for unsupported commands

- mocktr181 currently only supports `set` and `get` commands
xmidt-org · Jul 16, 2024 · 95f2a20 · 95f2a20
1 parent a22907f
commit 95f2a20
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/internal/wrphandlers/mocktr181/handler.go b/internal/wrphandlers/mocktr181/handler.go
@@ -142,7 +142,8 @@ func (h Handler) HandleWrp(msg wrp.Message) error {
 
 	default:
 		// currently only get and set are implemented for existing mocktr181
-		statusCode = http.StatusOK
+		statusCode = 520
+		payloadResponse = []byte(fmt.Sprintf(`{"message": "command %s is not support"}`, command))
 	}
 
 	response := msg

diff --git a/internal/wrphandlers/mocktr181/handler_test.go b/internal/wrphandlers/mocktr181/handler_test.go
@@ -91,6 +91,21 @@ func TestHandler_HandleWrp(t *testing.T) {
 				a.Equal(int64(520), *msg.Status)
 				a.True(h.Enabled())
 
+				return nil
+			},
+		}, {
+			description:     "unknown command",
+			egressCallCount: 1,
+			msg: wrp.Message{
+				Type:        wrp.SimpleEventMessageType,
+				Source:      "dns:tr1d1um.example.com/service/ignored",
+				Destination: "event:event_1/ignored",
+				Payload:     []byte("{\"command\":\"FOOBAR\",\"parameters\":[{\"name\":\"Device.Bridging.MaxBridgeEntries\",\"dataType\":0,\"value\":\"anothername\",\"attributes\":{\"notify\":0}}]}"),
+			},
+			validate: func(a *assert.Assertions, msg wrp.Message, h *Handler) error {
+				a.Equal(int64(520), *msg.Status)
+				a.True(h.Enabled())
+
 				return nil
 			},
 		},