[FE] 송금 페이지 url에 멤버 id 보이지 않게 변경 #875
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
pakxe
approved these changes
Dec 24, 2024
pakxe
approved these changes
Dec 24, 2024
| @@ -15,7 +15,7 @@ const UserEventLogin = lazy(() => import('@pages/event/[eventId]/admin/login/use | |||
| const EventLoader = lazy(() => import('@components/Loader/EventLoader')); | |||
| const AuthGate = lazy(() => import('@pages/event/[eventId]/admin/AuthGate')); | |||
| const EventPage = lazy(() => import('@pages/event/[eventId]/EventPageLayout')); | |||
| const SendPage = lazy(() => import('@pages/event/[eventId]/home/send/[memberId]/SendPage')); | |||
| const SendPage = lazy(() => import('@pages/event/[eventId]/home/send/SendPage')); | |||
There was a problem hiding this comment.
맞아요~ 저번 회의 때 토다리가 제안해줬던 것을 반영해봤어요.
확실히 더 깔끔해진 것 같아요
| @@ -14,7 +14,7 @@ export const ROUTER_URLS = { | |||
| editAccount: `${EVENT_WITH_EVENT_ID}/admin/edit-account`, | |||
| images: `${EVENT_WITH_EVENT_ID}/images`, | |||
| addImages: `${EVENT_WITH_EVENT_ID}/admin/add-images`, | |||
| send: `${EVENT_WITH_EVENT_ID}/home/send/:memberId`, | |||
| send: `${EVENT_WITH_EVENT_ID}/home/send`, | |||
There was a problem hiding this comment.
송금이라는 의미를 담은 이름으로 바꾸는 것도 좋을 것 같아용
There was a problem hiding this comment.
send가 송금이라는 의미로 안 와닿았을까요? 어떤 이름이 더 좋을 것 같나요?
|
url에 직접 입력하는 경우는 아래 사진처럼 나와요!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue
구현 사항
송금 페이지 url에 멤버 id 사용하지 않게 하여 page directory depth 감소
멤버 id를 넣은 의도는 참여자 별로 송금 페이지를 보여주고 싶어서 였습니다. 하지만 이 정보가 필수가 아님을 깨닫고 이를 지워도 충분히 참여자 별로 송금 페이지를 보여줄 수 있다는 것을 알게 되어서 멤버 id를 url에서 제거했습니다.
이제
${EVENT_WITH_EVENT_ID}/home/send/:memberId에서${EVENT_WITH_EVENT_ID}/home/send/로 변화합니다.🫡 참고사항