Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FE] 송금 페이지 url에 멤버 id 보이지 않게 변경 #875

Merged
merged 1 commit into from
Dec 27, 2024
Merged

[FE] 송금 페이지 url에 멤버 id 보이지 않게 변경 #875

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion client/src/constants/routerUrls.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export const ROUTER_URLS = {
editAccount: `${EVENT_WITH_EVENT_ID}/admin/edit-account`,
images: `${EVENT_WITH_EVENT_ID}/images`,
addImages: `${EVENT_WITH_EVENT_ID}/admin/add-images`,
send: `${EVENT_WITH_EVENT_ID}/home/send/:memberId`,
send: `${EVENT_WITH_EVENT_ID}/home/send`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

송금이라는 의미를 담은 이름으로 바꾸는 것도 좋을 것 같아용

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

send가 송금이라는 의미로 안 와닿았을까요? 어떤 이름이 더 좋을 것 같나요?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

send만 사용하는 것 보단 send-money는 어떠신가용? 좀 더 송금 느낌이 날 것 같아서요!

qrCode: `${EVENT_WITH_EVENT_ID}/qrcode`,
login: '/login',
myPage: '/mypage',
Expand Down
2 changes: 1 addition & 1 deletion client/src/hooks/useReportsPage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ const useReportsPage = () => {
eventToken,
};

navigate(`/${getEventBaseUrl(location.pathname)}/home/send/${memberId}`, {state: sendInfo});
navigate(`/${getEventBaseUrl(location.pathname)}/home/send`, {state: sendInfo});
};

const onCopy = async (amount: number) => {
Expand Down
0 ...ventId]/home/send/[memberId]/SendPage.tsx → ...es/event/[eventId]/home/send/SendPage.tsx
View file
Open in desktop
File renamed without changes.
4 changes: 2 additions & 2 deletions client/src/router.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import {createBrowserRouter, Navigate} from 'react-router-dom';
import {createBrowserRouter} from 'react-router-dom';
import {lazy, Suspense} from 'react';

import {ROUTER_URLS} from '@constants/routerUrls';
Expand All @@ -15,7 +15,7 @@ const UserEventLogin = lazy(() => import('@pages/event/[eventId]/admin/login/use
const EventLoader = lazy(() => import('@components/Loader/EventLoader'));
const AuthGate = lazy(() => import('@pages/event/[eventId]/admin/AuthGate'));
const EventPage = lazy(() => import('@pages/event/[eventId]/EventPageLayout'));
const SendPage = lazy(() => import('@pages/event/[eventId]/home/send/[memberId]/SendPage'));
const SendPage = lazy(() => import('@pages/event/[eventId]/home/send/SendPage'));
const MainPage = lazy(() => import('@pages/main/MainPage'));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오우 경로가 깔끔해졌네요

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

맞아요~ 저번 회의 때 토다리가 제안해줬던 것을 반영해봤어요.
확실히 더 깔끔해진 것 같아요

const HomePage = lazy(() => import('@pages/event/[eventId]/home/HomePage'));
const AdminPage = lazy(() => import('@pages/event/[eventId]/admin/AdminPage'));
Expand Down
Loading