-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BE] chore: 단일 DB로 변경, 인메모리 메시지 브로커 적용 #746
Merged
Merged
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -37,3 +37,8 @@ spring: | |
sql: | ||
init: | ||
data-locations: | ||
|
||
management: | ||
health: | ||
rabbit: | ||
enabled: false |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -27,35 +27,25 @@ management: | |
server: | ||
port: 8081 | ||
|
||
health: | ||
rabbit: | ||
enabled: false | ||
|
||
file: | ||
firebase: | ||
path: firebase-friendogly-private-key.json | ||
|
||
spring: | ||
rabbitmq: | ||
host: ${RABBITMQ_PROD_HOST} | ||
username: ${RABBITMQ_PROD_USERNAME} | ||
password: ${RABBITMQ_PROD_PASSWORD} | ||
port: 3100 # initial connection port: use 3100 instead of 5672 | ||
stomp-port: 9100 # STOMP port: use 9100 instead of 61613 | ||
sql: | ||
init: | ||
data-locations: | ||
|
||
datasource: | ||
writer: | ||
hikari: | ||
driver-class-name: com.mysql.cj.jdbc.Driver | ||
jdbc-url: ${WRITER_MYSQL_URL} | ||
read-only: false | ||
username: ${MYSQL_USERNAME} | ||
password: ${MYSQL_PASSWORD} | ||
reader: | ||
hikari: | ||
driver-class-name: com.mysql.cj.jdbc.Driver | ||
jdbc-url: ${READER_MYSQL_URL} | ||
read-only: true | ||
username: ${MYSQL_USERNAME} | ||
password: ${MYSQL_PASSWORD} | ||
driver-class-name: com.mysql.cj.jdbc.Driver | ||
url: ${MYSQL_PROD_RDS_URL} | ||
username: ${MYSQL_PROD_RDS_USERNAME} | ||
password: ${MYSQL_PROD_RDS_PASSWORD} | ||
|
||
Comment on lines
+44
to
+48
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 저희 mysql rds쓰나요..? |
||
jpa: | ||
hibernate: | ||
ddl-auto: validate | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
저희 모든 환경에서 인메모리 메세지로 바꿀 것 같은데
굳이 프로파일 설정안해도 될 것 같아요.
추가하신 특별한 이유가 있는지 궁금합니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
제 생각에는
InMemory를 현재 상황에서 local, dev, prod 모두에서 사용중이다
라는 것을 명시적으로 코드에서 보여주고 싶었던 것일 거 같아요. 그렇게 생각하니 좋아보이네요! 나중에 봤을 때 생각의 여지도 적어질 것 같구요There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
원래 환경별로 분리하는 것을 염두에 두고 작성한 코드였어서 그대로 두려고 했었는데
지금 상황에서는 생략해도 좋아보이네요