[BE] chore: 단일 DB로 변경, 인메모리 메시지 브로커 적용 #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takoyakimchi
requested review from
ehtjsv2,
jimi567 and
J-I-H-O
as code owners
Test Results226 tests +149 226 ✅ +149 20s ⏱️ +19s Results for commit 349697f. ± Comparison against base commit 6bc242f. This pull request removes 77 and adds 226 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
jimi567
previously requested changes
Dec 2, 2024
Comment on lines
+44
to
+48
| driver-class-name: com.mysql.cj.jdbc.Driver | ||
| url: ${MYSQL_PROD_RDS_URL} | ||
| username: ${MYSQL_PROD_RDS_USERNAME} | ||
| password: ${MYSQL_PROD_RDS_PASSWORD} | ||
|
|
| @@ -12,16 +12,16 @@ | |||
| import org.springframework.web.socket.config.annotation.StompEndpointRegistry; | |||
| import org.springframework.web.socket.config.annotation.WebSocketMessageBrokerConfigurer; | |||
|
|
|||
| @Profile("local") | |||
| @Profile("local | dev | prod") | |||
There was a problem hiding this comment.
저희 모든 환경에서 인메모리 메세지로 바꿀 것 같은데
굳이 프로파일 설정안해도 될 것 같아요.
추가하신 특별한 이유가 있는지 궁금합니다.
There was a problem hiding this comment.
제 생각에는 InMemory를 현재 상황에서 local, dev, prod 모두에서 사용중이다 라는 것을 명시적으로 코드에서 보여주고 싶었던 것일 거 같아요. 그렇게 생각하니 좋아보이네요! 나중에 봤을 때 생각의 여지도 적어질 것 같구요
There was a problem hiding this comment.
원래 환경별로 분리하는 것을 염두에 두고 작성한 코드였어서 그대로 두려고 했었는데
지금 상황에서는 생략해도 좋아보이네요
ehtjsv2
previously approved these changes
Dec 3, 2024
ehtjsv2
approved these changes
Dec 3, 2024
J-I-H-O
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈
개발 사항
전달 사항 (없으면 삭제해 주세요)