-
Notifications
You must be signed in to change notification settings - Fork 714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
experimental: add backface-visibility property for transforms #3802
Conversation
…studio into add-backface-visibility
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to think more about this
- its a bit weird having so much custom logic for backface visibility
- is hiding using a "hidden" as a value in all other cases? why not here as well? Or is it that the property gets removed while its hidden? in that case same question, why not here as well?
- since we take space for select control, why not use combobox and support other values as well like we do in such cases? I think when we designed it we weren't thinking about it
- scale shouldn't be released without the lock
- all properties miss descriptions in tooltips
- please hide the transforms behind a feature flag because its not ready
For all other cases when it is hidden like But some properties still set to
The actual |
@JayaKrishnaNamburu don't we want to support global values when possible? |
Yeah true, missed it here with select 👍 |
## Description This PR helps in returning empty strings for keyword values which are hidden from the UI. This support is needed in #3802 backface-visibility in transforms ## Code Review - [ ] hi @kof, I need you to do - conceptual review (architecture, feature-correctness) - detailed review (read every line) - test it on preview ## Before requesting a review - [x] made a self-review - [x] added inline comments where things may be not obvious (the "why", not "what")
apps/builder/app/builder/features/style-panel/sections/transforms/transform-utils.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works nicely
Description
Allow to add
backface-visibility
property in the transforms section.hidden
is not possible on thebackface-visibility
property. Because it takes onlyvisible
orhidden
as value. The other way to simulate hidden is to reset the value tovisible
because that's the default value for property. But i don't think it's really needed to manage this.Steps for reproduction
+
icon on the transforms section.Backface Visibility
Code Review
Before requesting a review
Before merging