Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

experimental: return empty values for hidden keyword properties #3879

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

JayaKrishnaNamburu
Copy link
Contributor

Description

This PR helps in returning empty strings for keyword values which are hidden from the UI. This support is needed in #3802 backface-visibility in transforms

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

@JayaKrishnaNamburu JayaKrishnaNamburu self-assigned this Aug 5, 2024
@JayaKrishnaNamburu JayaKrishnaNamburu merged commit 679b98d into main Aug 5, 2024
14 checks passed
@JayaKrishnaNamburu JayaKrishnaNamburu deleted the hide-keyword-value branch August 5, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants