removed property files #30
Conversation
| if(TauUtil.modelPath == null) { | ||
| TauUtil.getProperties(); | ||
| if (modelPath != null) { | ||
| TauUtil.modelPath = modelPath; |
There was a problem hiding this comment.
Can this be made non-global.
An example use case is multiple AuxTtRef's processing different model directories from the same process...
There was a problem hiding this comment.
Not easily, a number of different classes reference the tau util model path
There was a problem hiding this comment.
Same issue as usgs/neic-locator#21 (comment) , using global's makes it difficult to access multiple modelPaths within the same process. Can those other things using model path receive it as a parameter or similar?
There was a problem hiding this comment.
My goal with the TT library right now is to keep it functional to support neic-locator and locator evaluation. I would prefer that we make this comment into an issue that can be addressed when I do the code review/standards pass for TT lib after the locator is in testing.
This PR removes the property file (and cwbproperty class) associated with neic-traveltime in favor of an optional path passed as a function argument with a default of "./models/". At this time I have done the minimum required to support what neic-locator expects, with the intent that this path will become a command line argument or service config file during the full neic-traveltime code review.