removed prop file, added cmd line, added example

[jpatton-USGS]

• removed use of property file(s) this depends on the corresponding neic-traveltime changes to be merged.
• added (optional) command line args for strings retrieved from property files.
• added example input and output (old style format to start)

[jmfee-usgs]

Please add an example of how to run the example input to the readme.

[jmfee-usgs]

Does this still need to be global?

[jpatton-USGS]

No, it didn't.

[jmfee-usgs]

use all caps and final for static, e.g.

public static final String DEFAULT_MODEL_PATH = "./models/";

[jmfee-usgs]

Reverse this check.

if (modelPath == null) {
    modelPath = DEFAULT_MODEL_PATH;
}

[jmfee-usgs]

see other related changes

[jpatton-USGS]

This one is correct, if the provided event path does not equal null, then set the LocUtil.eventPath to it, otherwise let the default value in LocUtil.eventPath stand (if the provided event path is null)

[jmfee-usgs]

positional arguments may not be the best, you could use
--modelPath=PATH, then check for argument prefixes while parsing (and use defaults otherwise). Or only use argument prefixes for non-file inputs...

[jmfee-usgs]

I'm getting compile errors:

$ ./gradlew build

> Task :compileJava FAILED
.../neic-locator/src/main/java/gov/usgs/locator/LocMain.java:93: error: constructor TTSessionLocal in class TTSessionLocal cannot be applied to given types;
                                ttLocal = new TTSessionLocal(true, true, true, modelPath);
                                          ^
  required: boolean,boolean,boolean
  found: boolean,boolean,boolean,String
  reason: actual and formal argument lists differ in length
Note: .../neic-locator/lib/neic-traveltime/src/gov/usgs/traveltime/session/TTSession.java uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
1 error

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':compileJava'.
> Compilation failed; see the compiler error output for details.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 3s
3 actionable tasks: 2 executed, 1 up-to-date

[jpatton-USGS]

There's a corresponding traveltime pr, usgs/neic-traveltime#30 that needs to be merged first.

[jmfee-usgs]

Running the example is still awkward, and uses a hardcoded filename. Can --eventFile be made to use a specific file instead of a directory? Also, will you update the example command so it works without moving files around?

./gradlew build
cd build
java -jar libs/neic-locator-0.1.0.jar --modelPath=./models/ --eventFile=../examples/

[jpatton-USGS]

I made the --eventFile changes already in another branch that was supposed to be the next PR after this one (https://github.com/jpatton-USGS/neic-locator/tree/loc-service).

Small incremental PR's don't seem to be working out for this project, how do you suggest we do this? PR's up to the code standards pass and then one big one from there?

[mguy-usgs]

Based on John's most recent comment the requested change has been made, but in a branch PR after this one, so merging this PR so the next PR's can be reviewed accordingly