Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-17504 fix recursive update in XPathParts #3631

Merged
merged 1 commit into from
Apr 13, 2024
Merged

CLDR-17504 fix recursive update in XPathParts #3631

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions tools/cldr-code/src/main/java/org/unicode/cldr/util/XPathParts.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1211,10 +1211,13 @@ public XPathParts cloneAsThawed() {
}

public static XPathParts getFrozenInstance(String path) {
XPathParts result =
cache.computeIfAbsent(
path,
(String forPath) -> new XPathParts().addInternal(forPath, true).freeze());
XPathParts result = cache.get(path);
if (result == null) {
// CLDR-17504: This can recursively create new paths during creation so MUST NOT
// happen inside the lambda of computeIfAbsent(), but freezing the path is safe.
XPathParts unfrozen = new XPathParts().addInternal(path, true);
result = cache.computeIfAbsent(path, (String p) -> unfrozen.freeze());
}
return result;
}

Expand Down
Loading