Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-17504 fix recursive update in XPathParts #3631

Merged

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Apr 12, 2024

Co-authored-by: David Beaumont [email protected]

CLDR-17504

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

@srl295 srl295 requested a review from hagbard April 12, 2024 21:01
@srl295 srl295 self-assigned this Apr 12, 2024
@srl295 srl295 requested a review from a team April 12, 2024 21:01
@srl295 srl295 changed the base branch from main to maint/maint-45 April 12, 2024 21:01
@srl295 srl295 force-pushed the cldr-17504/more-recursive-update branch from 48bc11c to 7e38630 Compare April 12, 2024 21:03
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@srl295 srl295 force-pushed the cldr-17504/more-recursive-update branch from 7e38630 to dd2c30f Compare April 12, 2024 21:04
@srl295
Copy link
Member Author

srl295 commented Apr 12, 2024

@hagbard this is your spot fix - I'll clone the ticket for reducing further reentrancy (because it's really not needed)

Copy link
Contributor

@hagbard hagbard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'm ignoring the bot related warnings about other check annotations in unchanged files of course.

@hagbard hagbard merged commit b5fcd00 into unicode-org:maint/maint-45 Apr 13, 2024
10 checks passed
pedberg-icu pushed a commit to pedberg-icu/cldr that referenced this pull request Apr 22, 2024
Co-authored-by: David Beaumont <[email protected]>
(cherry picked from commit b5fcd00)
pedberg-icu pushed a commit that referenced this pull request Apr 22, 2024
Co-authored-by: David Beaumont <[email protected]>
(cherry picked from commit b5fcd00)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants