CLDR-16943 kbd: Normalization #3285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove <info normalization>, add <settings normalization> - dtd and spec update Co-authored-by: Marc Durdin <[email protected]>
miloush
reviewed
Sep 27, 2023
docs/ldml/tr35-keyboards.md
Outdated
| @@ -596,7 +585,7 @@ An element used to keep track of layout specific settings. This element may or m | |||
| **Syntax** | |||
|
|
|||
| ```xml | |||
| <settings [fallback="omit"] [transformFailure="omit"] [transformPartial="hide"] /> | |||
| <settings fallback="omit" normalization="mixed" /> | |||
There was a problem hiding this comment.
The brackets were denoting an optional attribute. You kept them above in the info element, it should be unified.
miloush
reviewed
Sep 27, 2023
- update xml
- expand about matching
mcdurdin
reviewed
Oct 2, 2023
docs/ldml/tr35-keyboards.md
Outdated
| > The implementation will apply normalization as appropriate when matching transform rules and `<display>` value matching. | ||
| > Output from the keyboard, following application of all transform rules, will be normalized to implementation or application-requested form. | ||
| > | ||
| > However, it is recognized that there may be some keyboards which, for compatibility or legacy reasons, need to manage their own normalization. The implementation in that case will do no normalization at all. The keyboard author must make use of transforms in the keyboard to any required normalization. |
There was a problem hiding this comment.
This needs to specify that normalization="mixed" is the attribute to enable this mode.
Perhaps it should be normalization="disabled" -- that seems clearer given the description
- previously 'mixed'
1 task
mcdurdin
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Marc Durdin [email protected]
CLDR-16943
ALLOW_MANY_COMMITS=true