CLDR-17092 kbd: drop settings fallback=omit #3309

srl295 · 2023-10-03T21:49:26Z

Note: depends on #3285 — please review only the last commit until I fix up the order

ALLOW_MANY_COMMITS=true

jira-pull-request-webhook · 2023-10-04T15:13:48Z

Notice: the branch changed across the force-push!

keyboards/3.0/mt-t-k0-47key.xml is no longer changed in the branch
keyboards/3.0/mt.xml is no longer changed in the branch
tools/cldr-code/src/test/resources/org/unicode/cldr/tool/KeyboardFlatten/broken-import-missing.xml is no longer changed in the branch
tools/cldr-code/src/test/resources/org/unicode/cldr/tool/KeyboardFlatten/broken-import-unknownbase.xml is no longer changed in the branch
tools/cldr-code/src/test/resources/org/unicode/cldr/tool/KeyboardFlatten/broken-import-unknownver.xml is no longer changed in the branch
tools/cldr-code/src/test/resources/org/unicode/cldr/tool/KeyboardFlatten/broken-import-wrongparent.xml is no longer changed in the branch

~ Your Friendly Jira-GitHub PR Checker Bot

srl295 · 2023-10-04T15:14:40Z

need a re-review due to rebase

srl295 requested a review from a team October 3, 2023 21:49

srl295 self-assigned this Oct 3, 2023

srl295 added the keyboard label Oct 3, 2023

mcdurdin previously approved these changes Oct 4, 2023

View reviewed changes

CLDR-17092 kbd: drop fallback="omit"

1cb143e

srl295 dismissed mcdurdin’s stale review via 1cb143e October 4, 2023 15:13

srl295 force-pushed the srl295/kbd/cldr-17092-settings branch from 98628f9 to 1cb143e Compare October 4, 2023 15:13

srl295 requested review from mcdurdin and a team October 4, 2023 15:13

srl295 requested review from macchiati and miloush October 4, 2023 16:40

mcdurdin approved these changes Oct 5, 2023

View reviewed changes

srl295 merged commit 048d063 into main Oct 5, 2023
10 checks passed

srl295 deleted the srl295/kbd/cldr-17092-settings branch October 5, 2023 15:29

Provide feedback