Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add
IOLocalContextStorage
#214Add
IOLocalContextStorage
#214Changes from 9 commits
ac4175c
682abb6
5f460ee
e522ac8
d9a1079
c4410ab
6b542aa
b6a75a0
978ccef
9913704
b6c2b0f
8c31136
6e09fe2
fe7259e
d10303b
e60f793
39ba754
61d5af7
713736b
b9b8fd9
653ebf0
5cf5a4e
5ad342c
44ddc9a
05b886d
45c08f6
b54341a
333fd4e
f1f0925
5cd592f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason not to make this
lazy
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think 1 is sufficient, but this would be a stupid reason to have a fatal error, so I was generous.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't access
Context.root()
before the storage is initialized. Yikes!