Add `IOLocalContextStorage` #214

rossabaker · 2023-05-12T16:10:29Z

I think this is doomed, but putting it out there to continue the discussion in #202.

Edit by @NthPortal: it is not necessarily doomed

rossabaker

It's tantalizingly close to working, but I don't think it ever can.

java/common/src/main/scala/org/typelevel/otel4s/java/IOLocalContextStorage.scala

rossabaker · 2023-05-12T16:15:33Z

java/common/src/test/scala/org/typelevel/otel4s/java/ContextStorageSuite.scala

+          rootLog.setLevel(Level.FINE)
+          rootLog.getHandlers().head.setLevel(Level.FINE)
+        }
+        ioLocal <- IOLocal(null: Context)


We have to add the wrapper before we refer to Context, or else we get a FINE message that we're being ignored.

iRevive · 2023-05-14T19:33:01Z

Does it seamlessly propagate the context? At least from the examples, it seems it does.

rossabaker · 2023-05-18T02:35:32Z

I don't think it works at all, because the dispatched fibers have their own IOLocal state. But typelevel/cats-effect#3636 may open a new path.

java/common/src/test/scala/org/typelevel/otel4s/java/ContextStorageSuite.scala

build.sbt

examples/src/main/scala/ContextStorageExample.scala

build.sbt

Co-authored-by: Arman Bilge <[email protected]>

rossabaker · 2023-05-19T04:11:51Z

6b542aa probably belongs on main for general cleanliness. The motivator here is that the Java SDK loads its own testkit if it's present, in preference to any other SPI implementation, like ours.

examples/src/main/scala/ContextStorageExample.scala

rossabaker · 2023-05-19T04:14:34Z

java/common/src/main/scala/org/typelevel/otel4s/java/IOLocalContextStorageProvider.scala

+class IOLocalContextStorageProvider extends ContextStorageProvider {
+  def get(): ContextStorage =
+    new IOLocalContextStorage(
+      Eval.later(IOLocalContextStorageProvider.localContext)


We can't access Context.root() before the storage is initialized. Yikes!

java/common/src/main/scala/org/typelevel/otel4s/java/IOLocalContextStorageProvider.scala

examples/src/main/scala/ContextStorageExample.scala

rossabaker · 2023-05-19T13:22:16Z

java/common/src/main/scala/org/typelevel/otel4s/java/IOLocalContextStorageProvider.scala

+object IOLocalContextStorageProvider {
+  val localContext: IOLocal[Context] =
+    IOLocal[Context](Context.root())
+      .syncStep(100)


I think 1 is sufficient, but this would be a stupid reason to have a fatal error, so I was generous.

rossabaker · 2023-05-19T17:06:37Z

This is going to want to live in an SPI module. Having more than one on the classpath is like multiple slf4j bindings.

java/common/src/main/scala/org/typelevel/otel4s/java/IOLocalContextStorage.scala

Co-authored-by: Arman Bilge <[email protected]>

NthPortal · 2023-08-24T18:50:09Z

I just realised there's a small problem of this not being the same type of context used in the API of the java backend, and I'm not entirely sure how to deal with that

NthPortal · 2023-08-25T16:15:02Z

so, with the new context implementation, if we use our own context and just have the custom ContextStorage unbox it, that should work fine. but we also need to expose access to a Local[F, Context] so that scala API users can access the context

NthPortal · 2023-08-29T14:05:32Z

java/common/src/main/scala/org/typelevel/otel4s/java/IOLocalContextStorageProvider.scala

+import io.opentelemetry.context.ContextStorageProvider
+
+object IOLocalContextStorageProvider {
+  val localContext: IOLocal[Context] =


any reason not to make this lazy?

NthPortal · 2023-09-28T22:31:41Z

just want to drop a note that I've been working on this (with Ross' blessing), and have a working implementation with tests. there's just the teeny, tiny problem that it depends not just on an unreleased cats effect version but on one that's not even merged yet. so, uh. not sure quite what to do about that

iRevive · 2024-05-15T11:00:51Z

@razvanz thanks for pointing out! I guess I linked the wrong task/PR, and it closed automatically.

# Conflicts: # .github/workflows/ci.yml # build.sbt

build.sbt

oteljava/trace/src/main/scala/org/typelevel/otel4s/oteljava/trace/SpanBuilderImpl.scala

NthPortal · 2024-12-18T01:24:30Z

thanks for updating this @iRevive!

# Conflicts: # .github/workflows/ci.yml

Experimental IOLocalContextStorage

ac4175c

rossabaker commented May 12, 2023

View reviewed changes

armanbilge reviewed May 18, 2023

View reviewed changes

java/common/src/test/scala/org/typelevel/otel4s/java/ContextStorageSuite.scala Outdated Show resolved Hide resolved

Try typelevel/cats-effect#3636

682abb6

armanbilge reviewed May 18, 2023

View reviewed changes

build.sbt Outdated Show resolved Hide resolved

examples/src/main/scala/ContextStorageExample.scala Outdated Show resolved Hide resolved

build.sbt Outdated Show resolved Hide resolved

rossabaker and others added 6 commits May 18, 2023 17:45

Apply suggestions from code review

5f460ee

Co-authored-by: Arman Bilge <[email protected]>

Get latest cats-effect branch

e522ac8

Fine, have your headers

d9a1079

Unused import

c4410ab

Get testkit out of main dependenecies

6b542aa

Attmept at a ContextStorageProvider SPI

b6a75a0

rossabaker commented May 19, 2023

View reviewed changes

armanbilge reviewed May 19, 2023

View reviewed changes

java/common/src/main/scala/org/typelevel/otel4s/java/IOLocalContextStorageProvider.scala Outdated Show resolved Hide resolved

examples/src/main/scala/ContextStorageExample.scala Outdated Show resolved Hide resolved

Use syncStep to initialize the local context

978ccef

rossabaker commented May 19, 2023

View reviewed changes

rossabaker added 2 commits May 22, 2023 12:02

Update Cats Effect snapshot

9913704

Remove direct reference to IOLocalContextStorageProvider

b6c2b0f

armanbilge reviewed May 23, 2023

View reviewed changes

java/common/src/main/scala/org/typelevel/otel4s/java/IOLocalContextStorage.scala Outdated Show resolved Hide resolved

Unbox IOLocal

8c31136

Co-authored-by: Arman Bilge <[email protected]>

armanbilge mentioned this pull request Jun 28, 2023

IOLocal propagation for unsafe access typelevel/cats-effect#3636

Merged

armanbilge added 2 commits June 28, 2023 22:15

Merge branch 'main' into context-storage

6e09fe2

Fix compile, update to CE snapshot

fe7259e

NthPortal reviewed Aug 29, 2023

View reviewed changes

iRevive reopened this May 15, 2024

iRevive added 2 commits December 13, 2024 15:49

Merge branch 'upstream-main' into context-storage

61d5af7

# Conflicts: # .github/workflows/ci.yml # build.sbt

Update cats-effect, fix implementation

713736b

mergify bot added module:oteljava Features and improvements to the oteljava module module:sdk Features and improvements to the sdk module metrics Improvement to metrics module tracing Improvements to tracing module labels Dec 13, 2024

Fix CI workflow

b9b8fd9

armanbilge mentioned this pull request Dec 13, 2024

Fallback IOLocal#unsafeThreadLocal by a true ThreadLocal typelevel/cats-effect#4200

Closed

iRevive changed the title ~~Experimental IOLocalContextStorage~~ [CE 3.6] Experimental IOLocalContextStorage Dec 15, 2024

iRevive reviewed Dec 15, 2024

View reviewed changes

build.sbt Outdated Show resolved Hide resolved

NthPortal reviewed Dec 17, 2024

View reviewed changes

oteljava/trace/src/main/scala/org/typelevel/otel4s/oteljava/trace/SpanBuilderImpl.scala Show resolved Hide resolved

Use cats-effect 3.6.0-RC1

653ebf0

iRevive force-pushed the context-storage branch from ea9f53b to 653ebf0 Compare December 28, 2024 08:09

iRevive marked this pull request as ready for review December 28, 2024 08:09

iRevive added 2 commits December 28, 2024 10:31

Fix docs

5cf5a4e

Merge branch 'upstream-main' into context-storage

5ad342c

iRevive changed the title ~~[CE 3.6] Experimental IOLocalContextStorage~~ Add IOLocalContextStorage Dec 31, 2024

Add minimal documentation

44ddc9a

mergify bot added the documentation Improvements or additions to documentation label Dec 31, 2024

iRevive added 6 commits December 31, 2024 13:01

Run scalafix

05b886d

Update doc example

45c08f6

Regenerate ci.yml

b54341a

Merge branch 'refs/heads/upstream-main' into context-storage

333fd4e

# Conflicts: # .github/workflows/ci.yml

Regenerate ci.yml

f1f0925

Fix compilation issue

5cd592f

mergify bot added the module:core Features and improvements to core module label Dec 31, 2024

iRevive merged commit 6783b22 into main Dec 31, 2024
22 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `IOLocalContextStorage` #214

Add `IOLocalContextStorage` #214

rossabaker commented May 12, 2023 •

edited by NthPortal

Loading

rossabaker left a comment

rossabaker May 12, 2023

iRevive commented May 14, 2023

rossabaker commented May 18, 2023 •

edited

Loading

rossabaker commented May 19, 2023

rossabaker May 19, 2023

rossabaker May 19, 2023

rossabaker commented May 19, 2023

NthPortal commented Aug 24, 2023

NthPortal commented Aug 25, 2023

NthPortal Aug 29, 2023

NthPortal commented Sep 28, 2023

iRevive commented May 15, 2024

NthPortal commented Dec 18, 2024

Add IOLocalContextStorage #214

Add IOLocalContextStorage #214

Conversation

rossabaker commented May 12, 2023 • edited by NthPortal Loading

rossabaker left a comment

Choose a reason for hiding this comment

rossabaker May 12, 2023

Choose a reason for hiding this comment

iRevive commented May 14, 2023

rossabaker commented May 18, 2023 • edited Loading

rossabaker commented May 19, 2023

rossabaker May 19, 2023

Choose a reason for hiding this comment

rossabaker May 19, 2023

Choose a reason for hiding this comment

rossabaker commented May 19, 2023

NthPortal commented Aug 24, 2023

NthPortal commented Aug 25, 2023

NthPortal Aug 29, 2023

Choose a reason for hiding this comment

NthPortal commented Sep 28, 2023

iRevive commented May 15, 2024

NthPortal commented Dec 18, 2024

Add `IOLocalContextStorage` #214

Add `IOLocalContextStorage` #214

rossabaker commented May 12, 2023 •

edited by NthPortal

Loading

rossabaker commented May 18, 2023 •

edited

Loading