-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds ability to set alternate local folder for config/metadata directory #111
Adds ability to set alternate local folder for config/metadata directory #111
Conversation
✅ Deploy Preview for em27-retrieval-pipeline ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@dostuffthatmatters where should documentation for this be updated? |
Config directory location is specified via an environment variable
23acbda
to
4505d32
Compare
@dostuffthatmatters I think this PR is now ready, the documentation has also been updated. Let me know if you have any comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the implementation! Looks very minimal and useful. Good work.
I only have three remarks:
- the small adjustments to the docs
- avoid the chained calls
- refactor the import style
Also, could you please rename the utils.envutils
to utils.environment
?
Refinements
abe1e44
to
7098ff4
Compare
@dostuffthatmatters I think the requested changes have been updated, and there are a few threads on some of the comments that you can have a look at. |
Hi @cfleur, apologies for the late reply. There was other rather urgent things to do. Thank you for the refactoring. I marked some required changes above. Best, |
- Removes dependency of environment fuctions on each other, refactors variables - Updates documentation about how to export .env file in environment
- methods that get config path from environment placed inside types.Config class
Updates to location of functions getting the config directory environment variable has been changed from utils.environment -> types.Config in latest commit. A consequence of this is that it allows to input directly the value of the environment variable into Config.load method, reverting the original changes from this PR to calls to Config.load with an argument. However changes to file imports in these files remain, as they update import order to follow the PEP 8 style guide for imports, namely grouping imports by type and separating them by a space. |
@dostuffthatmatters are you okay with this or do you prefer the imports reverted in the now unchanged files? |
Hi @cfleur, no all good now. Thank you very much for implementing all the requested changes. The improvement looks very clean now! I will merge it in a bit after I run the complete tests. |
User can configure location of config directory by setting an environment variable. Rebases #109 off of v1.4.1. Closes #108. NOTE: documentation update needed!